-
Notifications
You must be signed in to change notification settings - Fork 112
Add bfp16 support #2228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
L-roro
wants to merge
16
commits into
Xilinx:main
Choose a base branch
from
L-roro:add-bfp16-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add bfp16 support #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add bfp16 support to IRON. It is currently incomplete since I have not been able to make Peano work for the examples I have written, but they are apparently working with chess. I open this draft pr in order to get some feedback from the team.
The logic for the lowering is to simply transform the new block float type into an integer type of the appropriate length from the builtin mlir dialect. This lowering is done before the lowering of the object fifos into DMABDOps to avoid conflicts with functions calls that assume they are dealing with builtin types beyond that point in the pipeline.
There are currently no additional transformations being done and therefore management of the bfps is let at the discretion of the programmer. Currently, bfps are referenced as a unit from IRON (1 bfp represents 8 or 16 floats) to avoid dividing a bfp during data movement. This is in contrast to the AIE API which defines its vectors by referencing the number of floats represented. See bfp_conversion/kernel.cc for example and additional explanations.
Currently, different bfp types are instantiated uniquely in IRON (bfp16ebs8, bfp16ebs16). Nevertheless, they translate into a single MLIR type that encompasses all such types and identifies them through their AIE API name. I believe this is a reasonable compromise between syntax complexity and maintainability, that allows both for general optimizations for all block types or for individual ones if needed (despite not supporting any currently).