Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Update various dependencies #36

Conversation

whistlingwoods
Copy link
Contributor

@whistlingwoods whistlingwoods commented Dec 28, 2022

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Reference: #26 (comment)

Description of the changes in your PR

Update checkstyle / guava to Fix security vulnerability to 8.38
[Security] Update ktlint to 0.40.0
Update dependency for core library desugaring to 1.1.5 Upgrade ExoPlayer to 2.11.8
Update junit from 4.13 to 4.13.2
Update okhttp from 3.12.11 to 3.12.13
Upgrade PrettyTime to 5.0.6
& VARIOUS other dependencies

Fixes the following issue(s)

  • Security Fixes & Updates

Relies on the following changes

This PR Updates the follwing dependencies

  • checkstyle / guava 8.32 to 8.38
  • core library desugaring 1.1.1 to 1.1.5
  • ExoPlayer to 2.11.6 to 2.11.8
  • groupieVersion = 2.8.0 2.8.1
  • junit from 4.13 to 4.13.2
  • ktlint to 0.35.0 to 0.40.0
  • leakCanaryVersion = '2.2 to 2.5
  • markwonVersion = '4.3.1 to 4.6.0
  • okhttp from 3.12.11 to 3.12.13
  • PrettyTime to 4.0.5 to 5.0.6 latest

Testing apk

debug.zip

Agreement

Update checkstyle / guava to Fix security vulnerability to 8.38
[Security] Update ktlint to 0.40.0
Update dependency for core library desugaring to 1.1.5
Upgrade ExoPlayer to 2.11.8
Update junit from 4.13.1 to 4.13.2 
Update okhttp from 3.12.12 to 3.12.13
Upgrade PrettyTime to 5.0.6
Copy link
Owner

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort, but as you already saw in my other post I'm not interested in maintaining this. So since I can't know if any incompatibilities occur through the updates I'
d rather not merge this.
Without the prettytime change I would just merge it and trust in semantic versioning.

@whistlingwoods
Copy link
Contributor Author

I have pushed a commit to revert prettytime dependency upgrade however i'll test app without this change if found no problems that can be done in separate PR because latest prettytime 5.0.6 contains more localizations like inclusion of certain my local languages which more preunified users might want to take advantage of.

@XiangRongLin XiangRongLin merged commit 448db7c into XiangRongLin:pre-unified Jan 12, 2023
@whistlingwoods whistlingwoods deleted the RSoulwin-Update-dependencies-for-security branch January 12, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants