Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon [1.2.0]: Refactor: Taskless and awaitless #244

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Conversation

Xian55
Copy link
Owner

@Xian55 Xian55 commented Jan 28, 2022

Refactor

  • Wait uses thread synchronization instead of Task.Delay there for async no longer needed. During wait there are no allocation.
  • Wait api has been slightly changed with better naming.
  • Input no longer user Task.Delay. During wait there are no allocation.
  • Many functions no longer async due Task.Delay has been replaced with Thread.Sleep.
  • NpcNameFinder uses thread synchronization instead of Task.Delay
  • FollowRouteGoal: uses Thread instead of Task while finding new possible target
  • ClassConfiguration: Approach and TargetNearestTarget keys having a bit higher Cooldown.
  • ApproachTargetGoal: less likely spam Tab during approach
  • CombatUtil: uses Wait properly

Fixes

  • Frontend: During FrameConfiguration the page will be unresponsive in order to avoid misconfiguration.
  • WowProcessInput: properly keep track of the pressed keys
  • CombagGoal: OnExit only stops the player if it has no target
  • LootGoal: Fixed an issue during corpseLocations has no elements

Addon

  • Due the big rewrite the addon version has been bumped to 1.2.0

Result

  • Avoiding many many allocation
  • Goal transitions much more smoother
  • Navigation Turn timing more precise
  • LootGoal and SkinningGoal takes less time to react to NpcNameFinder changes
  • Overall, there is significant speedup

…Task.Delay has been replaced with Thread.Sleep. Eliminated many overhead. Wait uses thread synchronization.
@Xian55 Xian55 added refactor This ticket concerns the possible simplification of code/data. enhancement This pull request implements a new feature. labels Jan 28, 2022
@Xian55 Xian55 changed the title Refactor: Task and awaitless Refactor: Taskless and awaitless Jan 28, 2022
@Xian55 Xian55 merged commit 7064433 into dev Jan 28, 2022
@Xian55 Xian55 deleted the refactor/wait-awaitless branch January 28, 2022 16:43
@Xian55 Xian55 changed the title Refactor: Taskless and awaitless Addon [1.2.0]: Refactor: Taskless and awaitless Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This pull request implements a new feature. refactor This ticket concerns the possible simplification of code/data.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant