Addon [1.2.0]: Refactor: Taskless and awaitless #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Wait
uses thread synchronization instead ofTask.Delay
there forasync
no longer needed. During wait there are no allocation.Wait
api has been slightly changed with better naming.Input
no longer userTask.Delay
. During wait there are no allocation.async
dueTask.Delay
has been replaced withThread.Sleep
.NpcNameFinder
uses thread synchronization instead ofTask.Delay
FollowRouteGoal
: usesThread
instead ofTask
while finding new possible targetClassConfiguration
: Approach and TargetNearestTarget keys having a bit higher Cooldown.ApproachTargetGoal
: less likely spamTab
during approachCombatUtil
: usesWait
properlyFixes
Frontend
: During FrameConfiguration the page will be unresponsive in order to avoid misconfiguration.WowProcessInput
: properly keep track of the pressed keysCombagGoal
: OnExit only stops the player if it has no targetLootGoal
: Fixed an issue duringcorpseLocations
has no elementsAddon
1.2.0
Result
LootGoal
andSkinningGoal
takes less time to react toNpcNameFinder
changes