Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: PPather less exception and logging #236

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Feature: PPather less exception and logging #236

merged 1 commit into from
Jan 24, 2022

Conversation

Xian55
Copy link
Owner

@Xian55 Xian55 commented Jan 24, 2022

  • Don't use exceptions for EOF :dense:
  • Don't try to parse that long MPQ file list, just read the DataConfig.MPQ dictionary to see what exists
  • Log less about PPather pathfinding and asset loading process

@Xian55
PPather: Dont use exceptions for EOF :dense: - Dont try to parse that…
7be37f4 
… long MPQ file list, just read the DataConfig.MPQ dictionary to see what exists - log less about PPather pathfinding and asset loading.
@Xian55 Xian55 added the enhancement This pull request implements a new feature. label Jan 24, 2022
@Xian55 Xian55 merged commit bceb653 into dev Jan 24, 2022
@Xian55 Xian55 deleted the feature/ppather/less-exception-and-logging branch January 24, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement This pull request implements a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Xian55