Skip to content
This repository was archived by the owner on Aug 12, 2018. It is now read-only.

Sets UTF-8 as default character encoding #69

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Sets UTF-8 as default character encoding #69

merged 1 commit into from
Nov 23, 2016

Conversation

QWp6t
Copy link
Contributor

@QWp6t QWp6t commented Jan 13, 2014

This is untested, but I don't see any reason it shouldn't work. If someone else wants to test it, go ahead.

If this isn't appropriate for Notepad2-mod, feel free to reject. I normally set this option in my ini file, but there are a couple of folks ( #67 ) asking for it to be implemented as the default out of the box.

@XhmikosR
Copy link
Owner

I don't mind merging this, but maybe the distrib/Notepad2.ini approach is better since it's less intrusive, i.e. no code change is needed.

My main problem is maintaining the custom patches, that's why I'm hesitant. I mean, if/when there's a new Notepad2 version, things will be pretty hard to merge... I remember when 4.2.25 was out, it was a pain.

I'm open to any ideas here...

@QWp6t
Copy link
Contributor Author

QWp6t commented Jan 14, 2014

Well since this is just a single line, I think maintaining the code should be easy to do across versions. I honestly won't be offended if you don't want to merge this, though. This pull request is strictly for those other guys. Since I set this in my INI, I'm fine either way.

@ghost
Copy link

ghost commented Apr 12, 2015

I agree, honestly it should be changed both places. Currently I am using
custom INI. Look at pclouds; he is a developer for git/git. His
real name is

Nguyễn Thái Ngọc Duy

Which in ANSI is

Nguy?n Thái Ng?c Duy

He cant even use his own name with Notepad2 and default settings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants