Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zsh completions, fix #173 #177

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Support zsh completions, fix #173 #177

merged 1 commit into from
Mar 14, 2023

Conversation

Freed-Wu
Copy link
Contributor

No description provided.

@Xfennec
Copy link
Owner

Xfennec commented Mar 13, 2023

Hi! Thanks for the request.

A couple things:

  • Can you add a comment a the start of _progress file to explain its purpose? For people not familiar with zsh, it can be hard to understand why this file is there for.
  • Can you update the uninstall target as well?

Julien.

@Freed-Wu
Copy link
Contributor Author

Fixed.

@Xfennec Xfennec merged commit ef6464b into Xfennec:master Mar 14, 2023
@Xfennec
Copy link
Owner

Xfennec commented Mar 14, 2023

Thank you. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freed-Wu @Xfennec