Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD support #151

Merged
merged 8 commits into from
Mar 4, 2021
Merged

FreeBSD support #151

merged 8 commits into from
Mar 4, 2021

Conversation

vthriller
Copy link
Contributor

@vthriller vthriller commented Feb 27, 2021

  • progress works,
  • progress -m works,
  • progress -p works,
  • also seems to be working as usual on linux after these changes.

Based on PR #78. Closes #77.

Well, quick-and-dirty it keeps being. For simplicity this patch keeps
reallocating `procstat` all over the place even though a lot of
information can be obtained in way fewer passes.
@vthriller
Copy link
Contributor Author

(Sorry for force-pushes: I've fixed a couple of segfaults caused by classical copy-paste errors and took that opportunity to re-read the code a day later to make sure I didn't miss anything else. This PR should be fine by now.)

@Xfennec
Copy link
Owner

Xfennec commented Mar 3, 2021

First, thanks for this work, it's awesome to get FreeBSD support for this tool.

I'm totally OK to merge such support, but I can't maintain this by myself, so I need to be sure that you're around if a future change implies changes in this part of the code, like @BestPig did in 2015 for the MacOS X port.

What's your opinion on that ?

@vthriller
Copy link
Contributor Author

Hey, why not, sign me up! While I don't log into FreeBSD machines that often, it's rather easy to spin up in a VM from a prebuilt image, and the rate of changes that this relatively simple project sees should make it quite comfortable to maintain in the future.

@Xfennec
Copy link
Owner

Xfennec commented Mar 4, 2021

Nice!

I've reviewed the patch and it's OK as-is for me, but do you want some time before I do the merge to add additional changes?

@vthriller
Copy link
Contributor Author

It seems to be working fine now, so I think this PR is essentially done.

@Xfennec Xfennec merged commit 416a3f7 into Xfennec:master Mar 4, 2021
@Xfennec
Copy link
Owner

Xfennec commented Mar 4, 2021

Thanks again for this work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile on FreeNAS 9.10
3 participants