Skip to content

[Bug]: Custom spells outside CC_TYPE never announce #16

Description

@Xerrion

Problem

The README advertises "Custom spells - Add any spell ID." However, Listeners/AuraListener.lua:142-145 has an early if not CC_TYPE[spellId] then return end that short-circuits before the custom-spell dispatch at line 187. Any spellId not in the hard-coded CC_TYPE table never reaches AnnounceCustom.

Result: custom spells are silently ineffective unless they happen to also be in the built-in CC list.

Proposed Solution

Move the custom-spell dispatch path before the CC_TYPE filter, OR introduce a dedicated CustomSpellListener that registers its own SPELL_AURA_APPLIED + SPELL_CAST_SUCCESS handlers (so custom spells are not tied to CC semantics at all).

Alternatives

  • Document the limitation: "custom spells must also be CC-type debuffs."
  • Auto-add user custom spells into CC_TYPE at runtime with a generic type label.

Open Questions (need design discussion)

  • What event types should custom spells support?
  • Should they also support buffs (HELPFUL), or only debuffs?
  • Should they support SPELL_CAST_SUCCESS for instant cast announcements?

Acceptance Criteria

  • A custom spellId that is not in CC_TYPE successfully announces when applied.
  • Documentation clarifies which event types are supported for custom spells.
  • No regression in existing CC announcements.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ListenersCombat log listeners (interrupt, CC/aura, dispel)C-BugUnexpected or incorrect behaviorD-ComplexMultiple files or systems involvedP-All-VersionsAffects all supported WoW versionsS-Needs-TriageNew issue awaiting review

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions