-
-
Notifications
You must be signed in to change notification settings - Fork 1
[Bug]: Custom spells outside CC_TYPE never announce #16
Copy link
Copy link
Open
Labels
A-ListenersCombat log listeners (interrupt, CC/aura, dispel)Combat log listeners (interrupt, CC/aura, dispel)C-BugUnexpected or incorrect behaviorUnexpected or incorrect behaviorD-ComplexMultiple files or systems involvedMultiple files or systems involvedP-All-VersionsAffects all supported WoW versionsAffects all supported WoW versionsS-Needs-TriageNew issue awaiting reviewNew issue awaiting review
Description
Activity
Metadata
Metadata
Assignees
Labels
A-ListenersCombat log listeners (interrupt, CC/aura, dispel)Combat log listeners (interrupt, CC/aura, dispel)C-BugUnexpected or incorrect behaviorUnexpected or incorrect behaviorD-ComplexMultiple files or systems involvedMultiple files or systems involvedP-All-VersionsAffects all supported WoW versionsAffects all supported WoW versionsS-Needs-TriageNew issue awaiting reviewNew issue awaiting review
Problem
The README advertises "Custom spells - Add any spell ID." However,
Listeners/AuraListener.lua:142-145has an earlyif not CC_TYPE[spellId] then return endthat short-circuits before the custom-spell dispatch at line 187. AnyspellIdnot in the hard-codedCC_TYPEtable never reachesAnnounceCustom.Result: custom spells are silently ineffective unless they happen to also be in the built-in CC list.
Proposed Solution
Move the custom-spell dispatch path before the
CC_TYPEfilter, OR introduce a dedicatedCustomSpellListenerthat registers its ownSPELL_AURA_APPLIED+SPELL_CAST_SUCCESShandlers (so custom spells are not tied to CC semantics at all).Alternatives
CC_TYPEat runtime with a generic type label.Open Questions (need design discussion)
HELPFUL), or only debuffs?SPELL_CAST_SUCCESSfor instant cast announcements?Acceptance Criteria
spellIdthat is not inCC_TYPEsuccessfully announces when applied.