Enum Typed variables coming in as strings

[awasser-omnispear]

I am using TypeScript and the accountingApi.getReportProfitAndLoss endpoint. The response from of this endpoint has some enum types. RowType being one of them, as seen below.

xero-node/src/gen/model/accounting/reportRow.ts

Line 5 in bfcaf1c

'rowType'?: RowType;

However, the actual data coming down is not an Enum, it is actually a string. This causes an error when comparing the value of the data to the enum.
I.E. row.rowType == RowType.Header will always be false.
row.rowType == 'Header' will work, but TypeScript indicates this as an error.
I should note, that this only affects the TypeScript typing. JavaScript works perfectly fine, since it does not enforce any types.

A workaround would be to use row.rowType.toString() == 'Header'. Since rowType comes in as a string anyway, calling toString() effectively does nothing, except to satisfy TypeScript.

I would like to see the row.rowType == RowType.Header code fragment work correctly for TypeScript users.

[mbyrne00]

Hrmmm ... another typescript issue. Just heads up that the dates are also incorrectly typed, format incorrectly documented and plain wrong and the team have simply ignored this blatant bug since Feb 2021. #487 (comment)

[sangeet-joy-tw]

Hey @awasser-omnispear

I have tried asserting rowType - row.rowType == RowType.Header for accountingApi.getReportProfitAndLoss() method in our xero-node sample app and it is working fine for me.

Xero-node version I am using is - 8.0.0

Here is the sample code on my local -

Could you please try with the latest xero-node version and let us know if you are still facing this issue ?

[awasser-omnispear]

Glad to see it working! Due to technical reasons, we cannot upgrade Xero-node yet in our project, but we're working on it. I won't be able to test in a reasonable amount of time.

I'm happy to close this issue with your example alone. This issue is over 2 years old, and if I encounter another problem, I'll just create fresh issue.