Update Go version to 1.9 (palantir#212)

Xenorith · Aug 26, 2017 · 6fbc06b · 6fbc06b
1 parent 8e38f16
commit 6fbc06b
Show file tree

Hide file tree

Showing 13 changed files with 92 additions and 48 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,35 +1,35 @@
 ### Docker images ###
-alpine-go-1.7: &alpine-go-1_7
+alpine-go-curr: &alpine-go-curr
   working_directory: /go/src/github.com/palantir/godel
   docker:
-    - image: nmiyake/go:alpine-go-1.7.6-t108
+    - image: nmiyake/go:alpine-go-1.9-t111
 
-alpine-go-1.8: &alpine-go-1_8
+alpine-go-prev: &alpine-go-prev
   working_directory: /go/src/github.com/palantir/godel
   docker:
-    - image: nmiyake/go:alpine-go-1.8.3-t108
+    - image: nmiyake/go:alpine-go-1.8.3-t111
 
 brew-go: &brew-go
   working_directory: /go/src/github.com/palantir/godel
   docker:
-    - image: nmiyake/go:brew-go-t108
+    - image: nmiyake/go:brew-go-t111
 
 darwin-linux: &darwin-linux
   working_directory: /go/src/github.com/palantir/godel
   docker:
-    - image: nmiyake/go:go-darwin-linux-1.8.3-t108
+    - image: nmiyake/go:go-darwin-linux-1.9-t111
 
 darwin-linux-no-cgo: &darwin-linux-no-cgo
   working_directory: /go/src/github.com/palantir/godel
   docker:
-    - image: nmiyake/go:go-darwin-linux-no-cgo-1.8.3-t108
+    - image: nmiyake/go:go-darwin-linux-no-cgo-1.9-t111
       environment:
         CGO_ENABLED: 0
 
 darwin-linux-rpm-fpm: &darwin-linux-rpm-fpm
   working_directory: /go/src/github.com/palantir/godel
   docker:
-    - image: nmiyake/go:go-darwin-linux-1.8.3-docker-17.03.0-ce-rpm-fpm-t108
+    - image: nmiyake/go:go-darwin-linux-1.9-docker-17.03.0-ce-rpm-fpm-t111
 
 ### Shared cache steps ###
 godel-gouser-cache-restore: &godel-gouser-cache-restore
@@ -77,6 +77,9 @@ store-test-results: &store-test-results
 go-install-packages: &go-install-packages
   run: go install $(./godelw packages)
 
+go-version: &go-version
+  run: go version
+
 godel-version: &godel-version
   run: ./godelw version
 
@@ -94,6 +97,7 @@ jobs:
     steps:
       - setup_remote_docker
       - checkout
+      - *go-version
       - *godel-gouser-cache-restore
       - *godel-version
       - *godel-gouser-cache-save
@@ -109,6 +113,7 @@ jobs:
     <<: *darwin-linux-no-cgo
     steps:
       - checkout
+      - *go-version
       - *godel-root-cache-restore
       - *godel-version
       - *godel-root-cache-save
@@ -125,6 +130,7 @@ jobs:
       <<: *darwin-linux-no-cgo
       steps:
         - checkout
+        - *go-version
         - *godel-root-cache-restore
         - *godel-version
         - *godel-root-cache-save
@@ -140,6 +146,7 @@ jobs:
     <<: *darwin-linux
     steps:
       - checkout
+      - *go-version
       - *godel-root-cache-restore
       - *godel-version
       - *godel-root-cache-save
@@ -157,6 +164,7 @@ jobs:
     <<: *darwin-linux-no-cgo
     steps:
       - checkout
+      - *go-version
       - *godel-root-cache-restore
       - *godel-version
       - *godel-root-cache-save
@@ -169,32 +177,33 @@ jobs:
       - *store-artifacts
 
   ### Integration tests ###
-  integration-alpine-go-1.7:
-    <<: *alpine-go-1_7
+  integration-alpine-go-curr:
+    <<: *alpine-go-curr
     steps:
-      - run: apk update && apk add --no-cache openssh
       - checkout
+      - *go-version
       - *godel-root-cache-restore
       - *godel-version
       - *godel-root-cache-save
       - *go-install-packages
-      - run: echo 'export TESTS_NAME=integration-alpine-go1.7' >> $BASH_ENV
+      - run: echo 'export TESTS_NAME=integration-alpine-go-curr' >> $BASH_ENV
       - *define-tests-dir
       - *mkdir-tests-dir
       - run: ./godelw test --tags=integration --junit-output="${TESTS_DIR}/${CIRCLE_PROJECT_REPONAME}-${TESTS_NAME}-tests.xml"
       - *store-test-results
       - *store-artifacts
 
-  integration-alpine-go-1.8:
-    <<: *alpine-go-1_8
+  integration-alpine-go-prev:
+    <<: *alpine-go-prev
     steps:
       - run: apk update && apk add --no-cache openssh
       - checkout
+      - *go-version
       - *godel-root-cache-restore
       - *godel-version
       - *godel-root-cache-save
       - *go-install-packages
-      - run: echo 'export TESTS_NAME=integration-alpine-go1.8' >> $BASH_ENV
+      - run: echo 'export TESTS_NAME=integration-alpine-go-prev' >> $BASH_ENV
       - *define-tests-dir
       - *mkdir-tests-dir
       - run: ./godelw test --tags=integration --junit-output="${TESTS_DIR}/${CIRCLE_PROJECT_REPONAME}-${TESTS_NAME}-tests.xml"
@@ -205,6 +214,7 @@ jobs:
     <<: *brew-go
     steps:
       - checkout
+      - *go-version
       - *godel-linuxbrew-cache-restore
       - *godel-version
       - *godel-linuxbrew-cache-save
@@ -220,11 +230,12 @@ jobs:
     <<: *darwin-linux-no-cgo
     steps:
       - checkout
+      - *go-version
       - *godel-root-cache-restore
       - *godel-version
       - *godel-root-cache-save
       - *go-install-packages
-      - run: echo 'export TESTS_NAME=integration-go1.8' >> $BASH_ENV
+      - run: echo 'export TESTS_NAME=integration-go-std' >> $BASH_ENV
       - *define-tests-dir
       - *mkdir-tests-dir
       - run: ./godelw test --tags=integration --junit-output="${TESTS_DIR}/${CIRCLE_PROJECT_REPONAME}-${TESTS_NAME}-tests.xml"
@@ -236,6 +247,7 @@ jobs:
     <<: *darwin-linux-no-cgo
     steps:
       - checkout
+      - *go-version
       - *godel-root-cache-restore
       - *godel-version
       - *godel-root-cache-save
@@ -246,6 +258,7 @@ jobs:
     <<: *darwin-linux-no-cgo
     steps:
       - checkout
+      - *go-version
       - *godel-root-cache-restore
       - *godel-version
       - *godel-root-cache-save
@@ -258,6 +271,7 @@ jobs:
     <<: *darwin-linux-no-cgo
     steps:
       - checkout
+      - *go-version
       - *godel-root-cache-restore
       - *godel-version
       - *godel-root-cache-save
@@ -291,11 +305,11 @@ workflows:
          filters:
            tags:
              only: /.*/
-      - integration-alpine-go-1.7:
+      - integration-alpine-go-curr:
          filters:
            tags:
              only: /.*/
-      - integration-alpine-go-1.8:
+      - integration-alpine-go-prev:
          filters:
            tags:
              only: /.*/
@@ -318,8 +332,8 @@ workflows:
             - godel
             - gonform
             - gunit
-            - integration-alpine-go-1.7
-            - integration-alpine-go-1.8
+            - integration-alpine-go-curr
+            - integration-alpine-go-prev
             - integration-brew
             - integration-std
             - okgo
@@ -333,8 +347,8 @@ workflows:
             - godel
             - gonform
             - gunit
-            - integration-alpine-go-1.7
-            - integration-alpine-go-1.8
+            - integration-alpine-go-curr
+            - integration-alpine-go-prev
             - integration-brew
             - integration-std
             - okgo

diff --git a/apps/distgo/cmd/build/build_test.go b/apps/distgo/cmd/build/build_test.go
@@ -422,7 +422,7 @@ func TestBuildErrorMessage(t *testing.T) {
 		},
 	)
 
-	want := `(?s)^go install failed: build command \[.+go install ./foo\] run with additional environment variables \[GOOS=.+ GOARCH=.+\] failed with output:.+foo/main.go:1: syntax error: non-declaration statement outside function body$`
+	want := `(?s)^go install failed: build command \[.+go install ./foo\] run with additional environment variables \[GOOS=.+ GOARCH=.+\] failed with output:.+foo/main.go:1:15: syntax error: non-declaration statement outside function body$`
 
 	buf := &bytes.Buffer{}
 	err = build.Run([]params.ProductBuildSpec{buildSpec, buildSpec}, nil, build.Context{

diff --git a/apps/gonform/generated_src/internal/cmd/gofmt/amalgomated_flag/flag.go b/apps/gonform/generated_src/internal/cmd/gofmt/amalgomated_flag/flag.go
@@ -114,7 +114,7 @@ func newIntValue(val int, p *int) *intValue {
 }
 
 func (i *intValue) Set(s string) error {
-	v, err := strconv.ParseInt(s, 0, 64)
+	v, err := strconv.ParseInt(s, 0, strconv.IntSize)
 	*i = intValue(v)
 	return err
 }
@@ -150,7 +150,7 @@ func newUintValue(val uint, p *uint) *uintValue {
 }
 
 func (i *uintValue) Set(s string) error {
-	v, err := strconv.ParseUint(s, 0, 64)
+	v, err := strconv.ParseUint(s, 0, strconv.IntSize)
 	*i = uintValue(v)
 	return err
 }

diff --git a/...form/generated_src/internal/github.com/palantir/checks/ptimports/amalgomated_flag/flag.go b/...form/generated_src/internal/github.com/palantir/checks/ptimports/amalgomated_flag/flag.go
@@ -114,7 +114,7 @@ func newIntValue(val int, p *int) *intValue {
 }
 
 func (i *intValue) Set(s string) error {
-	v, err := strconv.ParseInt(s, 0, 64)
+	v, err := strconv.ParseInt(s, 0, strconv.IntSize)
 	*i = intValue(v)
 	return err
 }
@@ -150,7 +150,7 @@ func newUintValue(val uint, p *uint) *uintValue {
 }
 
 func (i *uintValue) Set(s string) error {
-	v, err := strconv.ParseUint(s, 0, 64)
+	v, err := strconv.ParseUint(s, 0, strconv.IntSize)
 	*i = uintValue(v)
 	return err
 }

diff --git a/...gunit/generated_src/internal/github.com/jstemmer/go-junit-report/amalgomated_flag/flag.go b/...gunit/generated_src/internal/github.com/jstemmer/go-junit-report/amalgomated_flag/flag.go
@@ -114,7 +114,7 @@ func newIntValue(val int, p *int) *intValue {
 }
 
 func (i *intValue) Set(s string) error {
-	v, err := strconv.ParseInt(s, 0, 64)
+	v, err := strconv.ParseInt(s, 0, strconv.IntSize)
 	*i = intValue(v)
 	return err
 }
@@ -150,7 +150,7 @@ func newUintValue(val uint, p *uint) *uintValue {
 }
 
 func (i *uintValue) Set(s string) error {
-	v, err := strconv.ParseUint(s, 0, 64)
+	v, err := strconv.ParseUint(s, 0, strconv.IntSize)
 	*i = uintValue(v)
 	return err
 }

diff --git a/apps/okgo/generated_src/internal/github.com/golang/lint/amalgomated_flag/flag.go b/apps/okgo/generated_src/internal/github.com/golang/lint/amalgomated_flag/flag.go
@@ -114,7 +114,7 @@ func newIntValue(val int, p *int) *intValue {
 }
 
 func (i *intValue) Set(s string) error {
-	v, err := strconv.ParseInt(s, 0, 64)
+	v, err := strconv.ParseInt(s, 0, strconv.IntSize)
 	*i = intValue(v)
 	return err
 }
@@ -150,7 +150,7 @@ func newUintValue(val uint, p *uint) *uintValue {
 }
 
 func (i *uintValue) Set(s string) error {
-	v, err := strconv.ParseUint(s, 0, 64)
+	v, err := strconv.ParseUint(s, 0, strconv.IntSize)
 	*i = uintValue(v)
 	return err
 }

diff --git a/apps/okgo/generated_src/internal/github.com/gordonklaus/ineffassign/amalgomated_flag/flag.go b/apps/okgo/generated_src/internal/github.com/gordonklaus/ineffassign/amalgomated_flag/flag.go
@@ -114,7 +114,7 @@ func newIntValue(val int, p *int) *intValue {
 }
 
 func (i *intValue) Set(s string) error {
-	v, err := strconv.ParseInt(s, 0, 64)
+	v, err := strconv.ParseInt(s, 0, strconv.IntSize)
 	*i = intValue(v)
 	return err
 }
@@ -150,7 +150,7 @@ func newUintValue(val uint, p *uint) *uintValue {
 }
 
 func (i *uintValue) Set(s string) error {
-	v, err := strconv.ParseUint(s, 0, 64)
+	v, err := strconv.ParseUint(s, 0, strconv.IntSize)
 	*i = uintValue(v)
 	return err
 }

diff --git a/apps/okgo/generated_src/internal/github.com/kisielk/errcheck/amalgomated_flag/flag.go b/apps/okgo/generated_src/internal/github.com/kisielk/errcheck/amalgomated_flag/flag.go
@@ -114,7 +114,7 @@ func newIntValue(val int, p *int) *intValue {
 }
 
 func (i *intValue) Set(s string) error {
-	v, err := strconv.ParseInt(s, 0, 64)
+	v, err := strconv.ParseInt(s, 0, strconv.IntSize)
 	*i = intValue(v)
 	return err
 }
@@ -150,7 +150,7 @@ func newUintValue(val uint, p *uint) *uintValue {
 }
 
 func (i *uintValue) Set(s string) error {
-	v, err := strconv.ParseUint(s, 0, 64)
+	v, err := strconv.ParseUint(s, 0, strconv.IntSize)
 	*i = uintValue(v)
 	return err
 }

diff --git a/apps/okgo/generated_src/internal/github.com/mdempsky/unconvert/amalgomated_flag/flag.go b/apps/okgo/generated_src/internal/github.com/mdempsky/unconvert/amalgomated_flag/flag.go
@@ -114,7 +114,7 @@ func newIntValue(val int, p *int) *intValue {
 }
 
 func (i *intValue) Set(s string) error {
-	v, err := strconv.ParseInt(s, 0, 64)
+	v, err := strconv.ParseInt(s, 0, strconv.IntSize)
 	*i = intValue(v)
 	return err
 }
@@ -150,7 +150,7 @@ func newUintValue(val uint, p *uint) *uintValue {
 }
 
 func (i *uintValue) Set(s string) error {
-	v, err := strconv.ParseUint(s, 0, 64)
+	v, err := strconv.ParseUint(s, 0, strconv.IntSize)
 	*i = uintValue(v)
 	return err
 }

diff --git a/...go/generated_src/internal/github.com/opennota/check/cmd/varcheck/amalgomated_flag/flag.go b/...go/generated_src/internal/github.com/opennota/check/cmd/varcheck/amalgomated_flag/flag.go
@@ -114,7 +114,7 @@ func newIntValue(val int, p *int) *intValue {
 }
 
 func (i *intValue) Set(s string) error {
-	v, err := strconv.ParseInt(s, 0, 64)
+	v, err := strconv.ParseInt(s, 0, strconv.IntSize)
 	*i = intValue(v)
 	return err
 }
@@ -150,7 +150,7 @@ func newUintValue(val uint, p *uint) *uintValue {
 }
 
 func (i *uintValue) Set(s string) error {
-	v, err := strconv.ParseUint(s, 0, 64)
+	v, err := strconv.ParseUint(s, 0, strconv.IntSize)
 	*i = uintValue(v)
 	return err
 }

diff --git a/.../generated_src/internal/github.com/palantir/checks/outparamcheck/amalgomated_flag/flag.go b/.../generated_src/internal/github.com/palantir/checks/outparamcheck/amalgomated_flag/flag.go
@@ -114,7 +114,7 @@ func newIntValue(val int, p *int) *intValue {
 }
 
 func (i *intValue) Set(s string) error {
-	v, err := strconv.ParseInt(s, 0, 64)
+	v, err := strconv.ParseInt(s, 0, strconv.IntSize)
 	*i = intValue(v)
 	return err
 }
@@ -150,7 +150,7 @@ func newUintValue(val uint, p *uint) *uintValue {
 }
 
 func (i *uintValue) Set(s string) error {
-	v, err := strconv.ParseUint(s, 0, 64)
+	v, err := strconv.ParseUint(s, 0, strconv.IntSize)
 	*i = uintValue(v)
 	return err
 }