Decompile DRA func_80133FCC #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't checked this locally but I think it's more like this https://decomp.me/scratch/zc3Px |
It is matching with the mentionned variable, thank you ! |
|
From what I remember D_800BD240 and D_800BD228 aren't real variables, they are offsets within g_XaMusicConfigs. |
sozud
reviewed
Dec 24, 2023
src/pc/stubs.c
Outdated
| @@ -119,6 +119,9 @@ s32 D_800987B4; | |||
| u8 g_PadsRepeatTimer[BUTTON_COUNT * PAD_COUNT]; | |||
| s32 D_80136410; | |||
| s32 D_80136414[]; | |||
| s32 D_8013B65C; | |||
| s32 D_800BD228; | |||
There was a problem hiding this comment.
g_XaMusicConfigs = 0x800BD224;
So use unk228 for D_800BD228 and 240 is probably the next element, by my count the struct is 16 bytes. So 0x800BD224+16+12 == g_XaMusicConfigs[pos + 1].unk22f?
There was a problem hiding this comment.
I didn't think about adding 1 to the sound pos, I finally got it to match with the field unk230 from that same structure, thanks !
Xeeynamo
approved these changes
Dec 25, 2023
sozud
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be good to go ?