Skip to content

Conversation

@Kyle-Ye
Copy link

@Kyle-Ye Kyle-Ye commented Jun 23, 2023

Motivation

See saagarjha/unxip@v1.1.3...v2.1

Context: XcodesOrg/XcodesApp#371

Test

Test it locally with

swift build -c release && cd .build/release & ./xcodes install 15.0 Beta --experimental-unxip

Result ❌:

Downloading with aria2 (/opt/homebrew/bin/aria2c)
(1/6) Downloading Xcode 15.0.0-Beta+15A5160n: 99%
(2/6) Unarchiving Xcode (This can take a while)
Using experimental unxip. If you encounter any issues, remove the flag and try again
The file “Xcode-15.0.0-Beta+15A5160n.xip” doesn’t exist.

@Kyle-Ye Kyle-Ye marked this pull request as ready for review June 23, 2023 18:27
@Kyle-Ye Kyle-Ye marked this pull request as draft June 23, 2023 18:42
@Kyle-Ye
Copy link
Author

Kyle-Ye commented Jun 23, 2023

Revert the UnxipOption from String back to URL. (Upstream implementation of 2.1 change Option's type to be String. However this will cause a issue here. So we still use the URL type here)

Add 55bed3e

Result ✅:

Downloading with aria2 (/opt/homebrew/bin/aria2c)
(1/6) Downloading Xcode 15.0.0-Beta+15A5160n: 99%
(2/6) Unarchiving Xcode (This can take a while)
Using experimental unxip. If you encounter any issues, remove the flag and try again
(3/6) Moving Xcode to /Applications/Xcode-15.0.0-Beta.app
(4/6) Moving Xcode archive Xcode-15.0.0-Beta+15A5160n.xip to the Trash
(5/6) Checking security assessment and code signing
(6/6) Finishing installation
xcodes requires superuser privileges in order to finish installation.
macOS User Password: 
Xcode 15.0.0-Beta has been installed to /Applications/Xcode-15.0.0-Beta.app

@Kyle-Ye Kyle-Ye marked this pull request as ready for review June 23, 2023 18:49
@MattKiazyk
Copy link
Contributor

@Kyle-Ye thanks for taking time to do this a long time ago. I always felt it was weird how we used it, so therefore I would like to make xcodes support unxip 3 which has it's own library now we can use without having to create our own binary or our own code.

I'm going to close this PR because of that - Thanks!

@MattKiazyk MattKiazyk closed this Feb 16, 2024
@Kyle-Ye Kyle-Ye deleted the feature/kyle/upgrade_unxip branch February 16, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants