InfoPane UI Tweaks #540
Merged
InfoPane UI Tweaks #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses content margins instead of padding when it can to avoid content clipping during scrolling - Also fixes a few indentation inconsistencies - Adds min width for platforms section
Contributor
|
Thanks @marlonjames71 - tweaks looks awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
I wanted to update the way the platform views looked when it comes to the position of the "Install" button. It sits below the platform title creating extra space unnecessarily in my opinion. This looked confusing to me because I thought there might have been missing text. My change in regards to that puts the "Install" button inline with the platform title. Benefits include:
Other Changes
ScrollView Content Clipping:
The InfoPane's scrollable content was getting clipped due to the padding that was added to the InfoPane. I fixed this with a new SwiftUI modifier:
contentMargins. I use an availability check first, so old clipped code will remain for anyone using macOS older that v14. This is nice since the added code is very minimal. The only change from the old is that the padding was moved into the InfoPane's file making it responsible for its own layout.Indentation Inconsistencies:
I usually reindent files to fix any indentation that needs fixin'.
README Update:
Because there were changes made to the UI in the info pane, I also went ahead and updated the images that show in the README file. Hope that's okay.
Here are some images