Skip to content

Handle preference alerts from the PlatformsListView #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

chickdan
Copy link
Contributor

@chickdan chickdan commented Jan 5, 2024

The expected alert when choosing to delete a platform was not appearing. If I opened the PreferencesView and moved it off to the side I can see the alert appear over it when clicking the delete button. After adding this change I was able to see the alert in the PlatformsListView.

Before:

Screenshot 2024-01-04 at 10 07 14 PM

After:

Screenshot 2024-01-04 at 10 06 20 PM

@MattKiazyk MattKiazyk added the 2.0 Beta Issues/Bugs with 2.0 Beta label Jan 19, 2024
@MattKiazyk MattKiazyk merged commit 0dc13d8 into XcodesOrg:main Jan 19, 2024
@MattKiazyk
Copy link
Contributor

Thanks @chickdan - short story is originally I had it in Settings, but forgot to move the alert with it!

@chickdan chickdan deleted the fix_missing_platform_list_alert branch January 19, 2024 19:03
@MattKiazyk MattKiazyk added the bugfix Fixes a bug label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 Beta Issues/Bugs with 2.0 Beta bugfix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants