Skip to content

Add default phone number selection when there is only one #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

redryerye
Copy link
Contributor

@redryerye redryerye commented Dec 19, 2023

When I only have one trusted phone number and see the number selection view, I often get confused since it is hard to distinguish a tappable section in the list without a row highlight.
This change will select a phone number as a default when only one option exists.

Single phone number Multiple phone number
Screenshot 2023-12-20 at 0 44 13 Screenshot 2023-12-20 at 0 43 32
Single phone number with row selected Multiple phone number with row selected
Screenshot 2023-12-20 at 0 43 06 Screenshot 2023-12-20 at 0 44 41

@redryerye redryerye marked this pull request as draft December 19, 2023 23:40
@redryerye redryerye marked this pull request as ready for review December 19, 2023 23:53
@MattKiazyk MattKiazyk added the enhancement New feature or request label Dec 20, 2023
Copy link
Contributor

@MattKiazyk MattKiazyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @redryerye!

@MattKiazyk MattKiazyk merged commit c85b3c2 into XcodesOrg:main Dec 20, 2023
@redryerye redryerye deleted the feat/preselect-phonenumber branch December 20, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants