German translation added #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @drct looks like your missing some changes to the XcodeProj to include it? I was going to take your PR for German because you create it first and the dictionary is the exact same as #245. If you're ok with it, I can take the other one instead, otherwise, could you fix it up to include those changes. Thanks |
|
@MattKiazyk Thanks. I have updated the branch to include also the changes to the XcodeProj file. Does this work for you? |
MattKiazyk
requested changes
Jun 14, 2022
Closed
Co-authored-by: Matt Kiazyk <mattkiazyk@gmail.com>
|
@MattKiazyk Created a commit with your suggestions. |
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added de.lproj folder containing Localizable.strings with German translation. No changes to Xcode's project file. First translation and github pull request for me, so I hope everything's alright. Cheers.