Fix: Don't try to redefine bool on C99 and higher #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mborgerson
reviewed
May 15, 2025
| @@ -369,7 +369,9 @@ | |||
| #endif | |||
|
|
|||
|
|
|||
| #if ! defined( __cplusplus ) && ! defined( bool ) | |||
| #if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L | |||
| #include <stdbool.h> | |||
There was a problem hiding this comment.
Why not just drop all the checks and just use stdbool.h? Do we care about supporting ancient C versions?
There was a problem hiding this comment.
I don't know how the situation is on Windows/MSVC, I know it didn't support modernish C versions in the past, so this was the easiest thing to do without having to fire up a Windows installation.
There was a problem hiding this comment.
CI builds on Windows with msvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compiler errors on newer GCC, where
boolis treated as a keyword.