Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Install executable file #34

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Dec 16, 2019

Signed-off-by: Philippe Coval rzr@users.sf.net

rzr added a commit to CrossStream/extract-xiso that referenced this pull request Dec 16, 2019
Forwarded: XboxDev#34
Signed-off-by: RzR <rzr@users.sf.net>
@JayFoxRox
Copy link
Member

JayFoxRox commented Dec 16, 2019

nit: We don't use prefix style commit messages for this repo anymore (we use <Verb> <something> on most our repositories; prefix is only used if the project is large enough - we had decided that extract-xiso isn't large enough).


nit: We also don't usually sign-off commits in the description (in fact, we don't sign-off at all).


Please avoid github references in the commit description as it will create ugly references and pingbacks in the future. We mostly keep our git repo separated from github (no cross-references).


Regarding the code change I'd have to look into the cmake install stuff as I've never used it. I'll request reviews from others who might know.

Out of curiosity: Is there any special reason why this is necessary? extract-xiso is fairly broken as discussed in #25 (comment) - for most purposes other tools will do a better job.
The primary use of it is in nxdk where it's submoduled (and most bugs can be tolerated); so at least in nxdk it wouldn't benefit from a make install (as nxdk is self-contained and not "installed").

This change will help to use downstream's debian packaging files
Copy link
Contributor

@LukeUsher LukeUsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks fine

@mborgerson
Copy link
Member

Thanks!

@mborgerson mborgerson merged commit 2df05cc into XboxDev:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants