-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for vacancies controller #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@proskurekov fix pls
spec/requests/vacancies_spec.rb
Outdated
let(:vacancy) { build(:vacancy) } | ||
|
||
describe "#index" do | ||
it "returns http status success" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove word "returns" in each specs
end | ||
|
||
describe "#new" do | ||
before { sign_in user } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if user is not company to redirect to root_page only test in code we will fix letter
before { sign_in user } | ||
|
||
context "when valid params" do | ||
let(:create_vacancy) { post vacancies_path, params: { vacancy: vacancy.attributes } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not create let for one spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@proskurekov approve
No description provided.