Better way to determine if a matrix is a phase times a real matrix #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #373 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1922 1923 +1
=========================================
+ Hits 1922 1923 +1
Continue to review full report in Codecov by Sentry.
|
DavidSPhillips
approved these changes
Aug 17, 2023
rachelchadwick
added a commit
that referenced
this pull request
Apr 29, 2024
commit 7c63905 Merge: 127a1a7 f935053 Author: Eli Bourassa <53090166+elib20@users.noreply.github.com> Date: Mon Apr 29 14:16:22 2024 -0400 Merge branch 'master' into internal_modes commit f935053 Author: Alberto Fumagalli <alberto@xanadu.ai> Date: Mon Apr 29 14:14:51 2024 -0400 Add codecov token to test workflow (#390) commit fe9e112 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Wed Apr 10 15:31:34 2024 -0400 Updates references (#384) * updates references * Updates biblio --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit 25b5f08 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Wed Feb 28 20:35:28 2024 -0500 Implements the pre-Iwasawa and Iwasawa decompositions. (#382) * First working version * First working version * First working version * better tests * better tests * Finally correct * Finally correct * putting the traingles in the right places * Removes unnecesary T * More tests * More tests and spell correction * More tests and spell correction * Removes unnecesary complex number usage * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> commit 127a1a7 Merge: e6de063 8759363 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Tue Feb 13 16:43:20 2024 -0500 Merge branch 'master' into internal_modes commit 8759363 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Thu Feb 1 16:57:23 2024 -0500 Better blochmessiah (#381) * Nicer BM * Updates changelog * Unnecesary import * More simplifications * More simplifications * one more * Updates docstring --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit 6247fc8 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Wed Jan 24 10:43:57 2024 -0500 Updates docstring and simplifies Williamson (#380) Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit 0b1af63 Author: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> Date: Thu Jan 11 17:09:32 2024 -0500 Increment version number to `0.22.0-dev` (#379) commit 544c457 Author: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> Date: Wed Jan 10 16:52:38 2024 -0500 bump version to `0.21.0` (#378) commit 2268bf0 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Thu Jan 4 11:12:27 2024 -0500 Adds extra degenerate tests with nonvac nullspace (#377) * Adds extra degenerate tests with nonvac nullspace * updates changelog * updates changelog * updates changelog * Removes unnecesary comment * Still breaking something * Simplifications still work * Simplifications still work * Fixes bug --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit 8ec2172 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Wed Nov 29 15:53:11 2023 -0500 Implements the Montrealer (#374) * Saving changes * Passes black * Passes black * Black * updates acknowledgements and changelog * updates acknowledgements and changelog * Adds montrealer * Adds Montrealer tests (#375) * Yanic the pirate * mtl test * mtl first tests * mtl test * test mtl * test montrealer * test montrealer * test Montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * tests montrealer * montrealer test * montrealer test * montrealer test * montrealer test * montrealer test * test montrealer * test montrealer * montrealer test * montrealer test * montrealer test * montrealer tests * montrealer tests * montrealer tests * montrealer tests * functions header update * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer ready for review * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer - failed tests * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * the rspms are now ordered * Passes black * garbage test file to be deleted later * minor changes * Done --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> * making bots happy * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Adds extra tests --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> Co-authored-by: Yanic Cardin <yanic.cardin.1@gmail.com> Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> commit 0e163bf Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Tue Aug 22 10:19:08 2023 -0400 Update symplectic.py (#372) * Update decompositions.py * New takagi * New takagi * Passes black * Simplifies blochmessiah * Simplifies blochmessiah * Found a case that breaks Takagi * Fixes all the tests * Fixes issues found by the linter * Adds extra test * Adds extra test * dummy * dummy * Update symplectic.py Removes `autonne` * relocates test * trying to make pylint happy --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit e999e49 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Thu Aug 17 12:55:45 2023 -0400 Better way to determine if a matrix is a phase times a real matrix (#373) * Add a better way to determine if a matrix is a phase times a real matrix and tests * CHANGELOG updates --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain>
rachelchadwick
added a commit
that referenced
this pull request
May 1, 2024
* First commit * Fixes bug * removes unused import * Working version * Passes black * removes unused function * removes unused function * Rachels code review (#385) * Minor fixes * passes black * Fix test * removes unused function * test error is raised * test error is raised * Passes black * Passes black --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> Co-authored-by: rachelchadwick <33873960+rachelchadwick@users.noreply.github.com> * Now the non-recursive function do not produce warning (#386) * Now the non-recursive function do not produce warning * Now the non-recursive function do not produce warning * Passes black * Simplifies the diagonal method * More tests, always * More tests, always * minor pylint improvements * Adds extra test * black * minor simplification * some tests pass * some tests pass * Moves the tests that take forever to the end of the test file * Passes black * Adds else --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> * Adds the warning (#388) * Adds the warning * passes black * Apply suggestions from code review Co-authored-by: rachelchadwick <33873960+rachelchadwick@users.noreply.github.com> * Update thewalrus/internal_modes/fock_density_matrices.py --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> Co-authored-by: rachelchadwick <33873960+rachelchadwick@users.noreply.github.com> * Windows fix for numba types (#389) * Fix numba types * Passes black * Apply suggestions from code review * Apply suggestions from code review * passes black * Make lists tuples * Check non-recursive * Tests with high tolerances * Run black * Update test_density_matrix * Minor changes --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> Co-authored-by: Nicolas Quesada <991946+nquesada@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: rachelchadwick <33873960+rachelchadwick@users.noreply.github.com> * removes unnecesary import * Squashed commit of the following: commit 7c63905 Merge: 127a1a7 f935053 Author: Eli Bourassa <53090166+elib20@users.noreply.github.com> Date: Mon Apr 29 14:16:22 2024 -0400 Merge branch 'master' into internal_modes commit f935053 Author: Alberto Fumagalli <alberto@xanadu.ai> Date: Mon Apr 29 14:14:51 2024 -0400 Add codecov token to test workflow (#390) commit fe9e112 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Wed Apr 10 15:31:34 2024 -0400 Updates references (#384) * updates references * Updates biblio --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit 25b5f08 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Wed Feb 28 20:35:28 2024 -0500 Implements the pre-Iwasawa and Iwasawa decompositions. (#382) * First working version * First working version * First working version * better tests * better tests * Finally correct * Finally correct * putting the traingles in the right places * Removes unnecesary T * More tests * More tests and spell correction * More tests and spell correction * Removes unnecesary complex number usage * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> commit 127a1a7 Merge: e6de063 8759363 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Tue Feb 13 16:43:20 2024 -0500 Merge branch 'master' into internal_modes commit 8759363 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Thu Feb 1 16:57:23 2024 -0500 Better blochmessiah (#381) * Nicer BM * Updates changelog * Unnecesary import * More simplifications * More simplifications * one more * Updates docstring --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit 6247fc8 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Wed Jan 24 10:43:57 2024 -0500 Updates docstring and simplifies Williamson (#380) Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit 0b1af63 Author: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> Date: Thu Jan 11 17:09:32 2024 -0500 Increment version number to `0.22.0-dev` (#379) commit 544c457 Author: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> Date: Wed Jan 10 16:52:38 2024 -0500 bump version to `0.21.0` (#378) commit 2268bf0 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Thu Jan 4 11:12:27 2024 -0500 Adds extra degenerate tests with nonvac nullspace (#377) * Adds extra degenerate tests with nonvac nullspace * updates changelog * updates changelog * updates changelog * Removes unnecesary comment * Still breaking something * Simplifications still work * Simplifications still work * Fixes bug --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit 8ec2172 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Wed Nov 29 15:53:11 2023 -0500 Implements the Montrealer (#374) * Saving changes * Passes black * Passes black * Black * updates acknowledgements and changelog * updates acknowledgements and changelog * Adds montrealer * Adds Montrealer tests (#375) * Yanic the pirate * mtl test * mtl first tests * mtl test * test mtl * test montrealer * test montrealer * test Montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * tests montrealer * montrealer test * montrealer test * montrealer test * montrealer test * montrealer test * test montrealer * test montrealer * montrealer test * montrealer test * montrealer test * montrealer tests * montrealer tests * montrealer tests * montrealer tests * functions header update * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer ready for review * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer - failed tests * test montrealer * test montrealer * test montrealer * test montrealer * test montrealer * the rspms are now ordered * Passes black * garbage test file to be deleted later * minor changes * Done --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> * making bots happy * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Adds extra tests --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> Co-authored-by: Yanic Cardin <yanic.cardin.1@gmail.com> Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> commit 0e163bf Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Tue Aug 22 10:19:08 2023 -0400 Update symplectic.py (#372) * Update decompositions.py * New takagi * New takagi * Passes black * Simplifies blochmessiah * Simplifies blochmessiah * Found a case that breaks Takagi * Fixes all the tests * Fixes issues found by the linter * Adds extra test * Adds extra test * dummy * dummy * Update symplectic.py Removes `autonne` * relocates test * trying to make pylint happy --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> commit e999e49 Author: Nicolas Quesada <991946+nquesada@users.noreply.github.com> Date: Thu Aug 17 12:55:45 2023 -0400 Better way to determine if a matrix is a phase times a real matrix (#373) * Add a better way to determine if a matrix is a phase times a real matrix and tests * CHANGELOG updates --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> * Revert "Squashed commit of the following:" This reverts commit 0f99b20. --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> Co-authored-by: rachelchadwick <33873960+rachelchadwick@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a minor tweak to how to identify whether a matrix is a real matrix times a phase. Instead of finding the phase looking at the first element of the array it now look at the element with the largest absolute value. These prevents being fooled if the first entry is 0.