-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage #14
Conversation
- refactor `simulations.py` so that setup logic is on its own function (instead of the `__main__` scope) and can be tested - test the generated output has the expected header and number of columns
Codecov Report
@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 94.05% 95.86% +1.80%
==========================================
Files 32 32
Lines 1835 1838 +3
==========================================
+ Hits 1726 1762 +36
+ Misses 109 76 -33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done on bringing the test coverage score up! I left a few comments and questions -- one of them was regarding modifying the test_benchmarks_examples by importing functions rather than simply importing the modules to see if they run:
What was the issue behind this approach? Is it that the codecov score becomes too low? In which case: is it preferable to create functions out of the examples and benchmarks (as you have) or simply to tell codecov to ignore the examples and benchmarks files (we do test them but only with import statements to see if they run - all the other functionality is tested in other places).
I'd please like your take on this before you get to the others!
Co-authored-by: ilan-tz <57886357+ilan-tz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - just a couple of small comments, and then we can merge.
… into improve-test-coverage
Context for changes
Bringing pytest/Codecov score to %95+
Example usage and tests
Performance results justifying changes
Workflow actions and tests
Expected benefits and drawbacks
Expected benefits:
Possible drawbacks:
Related Github issues
Checklist and integration statements
black
,docformatter
andpylint
configurations.B-
or higher. I also confirm that I have already merged other branches into this branch as required._version.py
based on semantic versioning. I recognize that the developers may create a Special Release including my changes.