Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RabbitMQ] Reusing healthy connection #352

Merged
merged 10 commits into from
Jan 20, 2020
Merged

[RabbitMQ] Reusing healthy connection #352

merged 10 commits into from
Jan 20, 2020

Commits on Dec 3, 2019

  1. Reusing same RabbitMQHealthCheck instance

    @rkarg-blizz
    rkarg-blizz committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    14495bd View commit details
    Browse the repository at this point in the history

  2. Explicit handling of null sslOption parameter 

    The `ConnectionFactory` doesn't handle a null SslOption field for amqp connections. It must be a created instance with Enabled=false

The constructor for a new `ConnectionFactory` will create a new SslOption already so only overwriting that default if something was passed in to the constructor.
    @rkarg-blizz
    rkarg-blizz committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    c60e42b View commit details
    Browse the repository at this point in the history

  3. Reusing existing connection if it's still open 

    Removing Lazy that was only created to return an already created instance
    @rkarg-blizz
    rkarg-blizz committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    bee79fc View commit details
    Browse the repository at this point in the history

  4. Using valid Uri string for tests

    @rkarg-blizz
    rkarg-blizz committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    4f81309 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2019

  1. Merge branch 'master' into master

    @rwkarg
    rwkarg authored Dec 5, 2019
    Configuration menu
    Copy the full SHA
    ec3dcdc View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Reconnect only used if a ConnectionFactory is available

    @rkarg-blizz
    rkarg-blizz committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    b3d7553 View commit details
    Browse the repository at this point in the history

  2. Adding initial unit tests of the RabbitMQHealthCheck itself

    @rkarg-blizz
    rkarg-blizz committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    cf8e8aa View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. [style] Using discard and throw expression pattern

    @rkarg-blizz
    rkarg-blizz committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    3584d00 View commit details
    Browse the repository at this point in the history

  2. [style] removing blank lines

    @rkarg-blizz
    rkarg-blizz committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    3b47a85 View commit details
    Browse the repository at this point in the history

  3. removing redundant tests 

    Functional Tests already cover these use cases
    @rkarg-blizz
    rkarg-blizz committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    388d7ac View commit details
    Browse the repository at this point in the history