Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MongoDB.Driver Package Version To 2.28.0 #2266

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

Alirexaa
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #2265

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on #2265 (comment) it seems that we should be able to sign the library now. Could you please remove the following line?

Thank you @Alirexaa !

@adamsitnik
Copy link
Collaborator

it seems that we should be able to sign the library now.

@eerhardt this will allow for signing the Aspire package as well. But I can not find SignAssembly in the Aspire repo. Does it mean you have given up on the signing?

@Alirexaa Alirexaa requested a review from adamsitnik July 29, 2024 20:36
Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Alirexaa !

@adamsitnik adamsitnik merged commit 65ab619 into master Jul 30, 2024
3 checks passed
@adamsitnik adamsitnik deleted the alirexaa/update-mobgodb.driver-package branch July 30, 2024 07:48
@eerhardt
Copy link
Collaborator

it seems that we should be able to sign the library now.

@eerhardt this will allow for signing the Aspire package as well. But I can not find SignAssembly in the Aspire repo. Does it mean you have given up on the signing?

We just ignore the signing warning in our repo:

https://github.com/dotnet/aspire/blob/d8369e0d6e579127fd47681342b96e14e057df9a/src/Components/Aspire.MongoDB.Driver/Aspire.MongoDB.Driver.csproj#L9

    <NoWarn>$(NoWarn);CS8002</NoWarn> <!-- MongoDB packages are not signed -->

@Jaben
Copy link

Jaben commented Aug 6, 2024

@adamsitnik Any ETA for when this will be released? Thanks!

@Alirexaa
Copy link
Collaborator Author

Alirexaa commented Aug 8, 2024

@unaizorrilla we need a new release here.

@ledouxpl
Copy link

@adamsitnik Could you please prioritize releasing the patch? It's currently preventing us from updating the MongoDB C# driver in our organization without having to take down the health checks.

@JacobAtchley
Copy link

JacobAtchley commented Aug 19, 2024

@adamsitnik Could you please prioritize releasing the patch? It's currently preventing us from updating the MongoDB C# driver in our organization without having to take down the health checks.

+1 we are also facing the same issue

@adamsitnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issue with MongoDB.Driver v2.28.0
6 participants