-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MongoDB.Driver Package Version To 2.28.0 #2266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on #2265 (comment) it seems that we should be able to sign the library now. Could you please remove the following line?
AspNetCore.Diagnostics.HealthChecks/src/HealthChecks.MongoDb/HealthChecks.MongoDb.csproj
Line 8 in da7f3a4
<SignAssembly>false</SignAssembly> |
Thank you @Alirexaa !
@eerhardt this will allow for signing the Aspire package as well. But I can not find |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @Alirexaa !
We just ignore the signing warning in our repo:
|
@adamsitnik Any ETA for when this will be released? Thanks! |
@unaizorrilla we need a new release here. |
@adamsitnik Could you please prioritize releasing the patch? It's currently preventing us from updating the MongoDB C# driver in our organization without having to take down the health checks. |
+1 we are also facing the same issue |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Please reference the issue this PR will close: #2265
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: