Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ApplicationStatusHealthCheck #2262

Closed
wants to merge 1 commit into from

Conversation

Mohamedzonkol
Copy link

@Mohamedzonkol Mohamedzonkol commented Jul 13, 2024

it is more robust, and easier to maintain. Here are the improvements: Use of using for automatic disposal.
Adding nullability support.
Simplifying the IsApplicationRunning check.
Implementing proper disposal pattern.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Please reference the issue this PR will close: #[issue number]

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

it is more robust, and easier to maintain. Here are the improvements:
Use of using for automatic disposal.
Adding nullability support.
Simplifying the IsApplicationRunning check.
Implementing proper disposal pattern.
@Mohamedzonkol
Copy link
Author

@dotnet-policy-service agree

@Mohamedzonkol
Copy link
Author

Mohamedzonkol commented Jul 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant