-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add existing README.md files to NuGet packages #2041
Merged
adamsitnik
merged 3 commits into
Xabaril:master
from
adamsitnik:includeReadmesInNugetorg
Sep 21, 2023
Merged
Add existing README.md files to NuGet packages #2041
adamsitnik
merged 3 commits into
Xabaril:master
from
adamsitnik:includeReadmesInNugetorg
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
reviewed
Sep 15, 2023
…ugetorg # Conflicts: # Directory.Build.props
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2041 +/- ##
==========================================
- Coverage 69.06% 67.34% -1.72%
==========================================
Files 179 270 +91
Lines 4613 8646 +4033
Branches 447 621 +174
==========================================
+ Hits 3186 5823 +2637
- Misses 1323 2662 +1339
- Partials 104 161 +57
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@adamsitnik NugetPackageExplorer tool may be helpful for such investigations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/
This should include our existing README.md in the NuGet packages, which should get them displayed at NuGet.org
Example from some Azure SDK NuGet package:
@ViktorHofer could you please verify the correctness of MSBuild syntax?
I've tested it by running the following command, changing the file extension to .zip and opening it with file explorer: