Fix for memory leak in NATS (#1217)

Xabaril · Jun 3, 2022 · 932e036 · 932e036
1 parent 557c28d
commit 932e036
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/samples/HealthChecks.UI.Branding/Startup.cs b/samples/HealthChecks.UI.Branding/Startup.cs
@@ -79,8 +79,7 @@ public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
         }
     }
 
-    public class RandomHealthCheck
-    : IHealthCheck
+    public class RandomHealthCheck : IHealthCheck
     {
         public Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context, CancellationToken cancellationToken = default)
         {

diff --git a/src/HealthChecks.Nats/DependencyInjection/NatsHealthCheckBuilderExtensions.cs b/src/HealthChecks.Nats/DependencyInjection/NatsHealthCheckBuilderExtensions.cs
@@ -39,9 +39,12 @@ public static IHealthChecksBuilder AddNats(
             var options = new NatsOptions();
             setup?.Invoke(options);
 
+            builder.Services
+               .AddSingleton(sp => new NatsHealthCheck(options));
+
             return builder.Add(new HealthCheckRegistration(
                 name ?? NAME,
-                sp => new NatsHealthCheck(options),
+                sp => sp.GetRequiredService<NatsHealthCheck>(),
                 failureStatus,
                 tags,
                 timeout));

diff --git a/src/HealthChecks.Nats/NatsHealthCheck.cs b/src/HealthChecks.Nats/NatsHealthCheck.cs
@@ -13,7 +13,7 @@ namespace HealthChecks.Nats
     /// </remarks>
     public sealed class NatsHealthCheck : IHealthCheck, IDisposable
     {
-        private static readonly ConnectionFactory _connectionFactory = new ConnectionFactory();
+        private static readonly ConnectionFactory _connectionFactory = new();
 
         private readonly NatsOptions _options;