Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHTTP client: Refactor "packet-up" mode, chasing "stream-up" #4150

Merged
merged 5 commits into from
Dec 11, 2024
+227 −242
Merged

XHTTP client: Refactor "packet-up" mode, chasing "stream-up" #4150

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f23afc
Add wroteRequest (not supported by quic-go)
RPRX Dec 11, 2024
31adc1f
Use XTLS/quic-go instead
RPRX Dec 11, 2024
abd739e
Client doesn't need `scMaxConcurrentPosts` anymore
RPRX Dec 11, 2024
9f2134c
GotConn is available in H3
RPRX Dec 11, 2024
31865ca
`scMaxConcurrentPosts` -> `scMaxBufferedPosts` (30 by default)
RPRX Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GotConn is available in H3
  • Loading branch information
@RPRX
RPRX authored Dec 11, 2024
commit 9f2134c47d9b10d7ddc6ac252f9b47daceda4d17
9 changes: 1 addition & 8 deletions transport/internet/splithttp/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,7 @@ func (c *DefaultDialerClient) OpenDownload(ctx context.Context, baseURL string)
gotDownResponse.Close()
}()

if !c.isH3 {
// in quic-go, sometimes gotConn is never closed for the lifetime of
// the entire connection, and the download locks up
// https://github.com/quic-go/quic-go/issues/3342
// for other HTTP versions, we want to block Dial until we know the
// remote address of the server, for logging purposes
<-gotConn.Wait()
}
<-gotConn.Wait()

lazyDownload := &LazyReader{
CreateReader: func() (io.Reader, error) {
Expand Down
Loading