Skip to content

Conversation

RomThpt
Copy link

@RomThpt RomThpt commented Sep 17, 2025

No description provided.

|:----------------------------------|:--------------|:--------------|
| `asfAccountTxnID` | 5 | Track the ID of this account's most recent transaction. Required for [`AccountTxnID`](../common-fields.md#accounttxnid) |
| `asfAllowTrustLineClawback` | 16 | Allow account to claw back tokens it has issued. _(Requires the Clawback amendment.)_ Can only be set if the account has an empty owner directory (no trust lines, offers, escrows, payment channels, checks, or signer lists). After you set this flag, it cannot be reverted. The account permanently gains the ability to claw back issued assets on trust lines. |
| `asfAllowTrustLineLocking` | 17 | Allow account to lock trust lines for **IOU** tokens it has issued. **IOU** Tokens: If the issuer's account does not have the `lsfAllowTrustLineLocking` flag set, the transaction fails with `tecNO_PERMISSION`. |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the EscrowCreate transaction fails with" perhaps ? I guess this can be polished.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this one is missing some important context.

  • "IOU" is specifically not a term we encourage since (a) tokens don't have to refer to amounts owed and (b) "IOU" has an unprofessional connotation
  • "Locking" on trust lines (allowing amounts to be escrowed) is completely unrelated to "locking" on MPTs (equivalent to deep freezing on trust lines). It's annoying that the terminology is like that, but we're stuck with it at this point.
  • This field is not currently available on mainnet because it requires the TokenEscrow amendment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the EscrowCreate transaction fails with" perhaps ? I guess this can be polished.

something like that

| `asfAllowTrustLineLocking` | 17 | Allow account to lock trust lines for tokens it has issued. If the issuer's account does not have the `lsfAllowTrustLineLocking` flag set, the `EscrowCreate` transaction fails with `tecNO_PERMISSION`. (Requires the TokenEscrow amendment.) |

@mDuo13
Copy link
Collaborator

mDuo13 commented Sep 17, 2025

Noting this one for #3260

@amarantha-k amarantha-k requested a review from mDuo13 September 18, 2025 18:15
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should merge this as currently worded, but also, we need to put in a bunch more fixes for the TokenEscrow docs.

|:----------------------------------|:--------------|:--------------|
| `asfAccountTxnID` | 5 | Track the ID of this account's most recent transaction. Required for [`AccountTxnID`](../common-fields.md#accounttxnid) |
| `asfAllowTrustLineClawback` | 16 | Allow account to claw back tokens it has issued. _(Requires the Clawback amendment.)_ Can only be set if the account has an empty owner directory (no trust lines, offers, escrows, payment channels, checks, or signer lists). After you set this flag, it cannot be reverted. The account permanently gains the ability to claw back issued assets on trust lines. |
| `asfAllowTrustLineLocking` | 17 | Allow account to lock trust lines for **IOU** tokens it has issued. **IOU** Tokens: If the issuer's account does not have the `lsfAllowTrustLineLocking` flag set, the transaction fails with `tecNO_PERMISSION`. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this one is missing some important context.

  • "IOU" is specifically not a term we encourage since (a) tokens don't have to refer to amounts owed and (b) "IOU" has an unprofessional connotation
  • "Locking" on trust lines (allowing amounts to be escrowed) is completely unrelated to "locking" on MPTs (equivalent to deep freezing on trust lines). It's annoying that the terminology is like that, but we're stuck with it at this point.
  • This field is not currently available on mainnet because it requires the TokenEscrow amendment.

@RomThpt
Copy link
Author

RomThpt commented Sep 24, 2025

Which specific wording issues should I address for this entry? And what other TokenEscrow docs need fixes - should we handle those in this PR or separately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants