-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add 'asfAllowTrustLineLocking' flag to accountset.md #3307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|:----------------------------------|:--------------|:--------------| | ||
| `asfAccountTxnID` | 5 | Track the ID of this account's most recent transaction. Required for [`AccountTxnID`](../common-fields.md#accounttxnid) | | ||
| `asfAllowTrustLineClawback` | 16 | Allow account to claw back tokens it has issued. _(Requires the Clawback amendment.)_ Can only be set if the account has an empty owner directory (no trust lines, offers, escrows, payment channels, checks, or signer lists). After you set this flag, it cannot be reverted. The account permanently gains the ability to claw back issued assets on trust lines. | | ||
| `asfAllowTrustLineLocking` | 17 | Allow account to lock trust lines for **IOU** tokens it has issued. **IOU** Tokens: If the issuer's account does not have the `lsfAllowTrustLineLocking` flag set, the transaction fails with `tecNO_PERMISSION`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the EscrowCreate
transaction fails with" perhaps ? I guess this can be polished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this one is missing some important context.
- "IOU" is specifically not a term we encourage since (a) tokens don't have to refer to amounts owed and (b) "IOU" has an unprofessional connotation
- "Locking" on trust lines (allowing amounts to be escrowed) is completely unrelated to "locking" on MPTs (equivalent to deep freezing on trust lines). It's annoying that the terminology is like that, but we're stuck with it at this point.
- This field is not currently available on mainnet because it requires the TokenEscrow amendment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the
EscrowCreate
transaction fails with" perhaps ? I guess this can be polished.
something like that
| `asfAllowTrustLineLocking` | 17 | Allow account to lock trust lines for tokens it has issued. If the issuer's account does not have the `lsfAllowTrustLineLocking` flag set, the `EscrowCreate` transaction fails with `tecNO_PERMISSION`. (Requires the TokenEscrow amendment.) |
Noting this one for #3260 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should merge this as currently worded, but also, we need to put in a bunch more fixes for the TokenEscrow docs.
|:----------------------------------|:--------------|:--------------| | ||
| `asfAccountTxnID` | 5 | Track the ID of this account's most recent transaction. Required for [`AccountTxnID`](../common-fields.md#accounttxnid) | | ||
| `asfAllowTrustLineClawback` | 16 | Allow account to claw back tokens it has issued. _(Requires the Clawback amendment.)_ Can only be set if the account has an empty owner directory (no trust lines, offers, escrows, payment channels, checks, or signer lists). After you set this flag, it cannot be reverted. The account permanently gains the ability to claw back issued assets on trust lines. | | ||
| `asfAllowTrustLineLocking` | 17 | Allow account to lock trust lines for **IOU** tokens it has issued. **IOU** Tokens: If the issuer's account does not have the `lsfAllowTrustLineLocking` flag set, the transaction fails with `tecNO_PERMISSION`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this one is missing some important context.
- "IOU" is specifically not a term we encourage since (a) tokens don't have to refer to amounts owed and (b) "IOU" has an unprofessional connotation
- "Locking" on trust lines (allowing amounts to be escrowed) is completely unrelated to "locking" on MPTs (equivalent to deep freezing on trust lines). It's annoying that the terminology is like that, but we're stuck with it at this point.
- This field is not currently available on mainnet because it requires the TokenEscrow amendment.
Which specific wording issues should I address for this entry? And what other TokenEscrow docs need fixes - should we handle those in this PR or separately? |
No description provided.