Fix minor issues with Code Samples #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The description gets deleted if it matches the title exactly (due to how our plugin finds the text of the README). Changed a couple instances to not match exactly so this doesn't happen. - Changed the top level of the Code Sampels layout to be a <main> element, which allows some styles to apply correctly and also helps the search crawler find the contents of the page.
mDuo13
added
bug
|
The description on the last card needs to be fixed. |
|
Yep, that was another instance of the same problem. It turns out, the "feature" of removing text that matches the title was not even needed, so I removed it entirely. Also fixed another typo I spotted along the way. |
AKCodez
approved these changes
Feb 5, 2025
| @@ -29,7 +29,7 @@ export default function CodeSamples() { | |||
| const { codeSamples, langs } = usePageSharedData<any>('code-samples'); | |||
|
|
|||
| return ( | |||
| <div className="landing page-community"> | |||
| <main className="landing page-code-samples"> | |||
There was a problem hiding this comment.
I cant find any references to this className in the codebase. Maybe we can remove this? Otherwise LGTM
There was a problem hiding this comment.
It's not used now but it's available if we need it later. Putting it there (on the correct element) is future-proofing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<main>element, which allows some styles to apply correctly and also helps the search crawler find the contents of the page.