Skip to content

fix: Stop tx processing if failed to delete expired credentials (#6715)#6962

Open
oleks-rip wants to merge 5 commits intoXRPLF:developfrom
oleks-rip:del_cred4
Open

fix: Stop tx processing if failed to delete expired credentials (#6715)#6962
oleks-rip wants to merge 5 commits intoXRPLF:developfrom
oleks-rip:del_cred4

Conversation

@oleks-rip
Copy link
Copy Markdown
Collaborator

@oleks-rip oleks-rip commented Apr 16, 2026

High Level Overview of Change

Return error code if deleting expired credentials failed

Ports #6715, which is based on 3.1.x, to develop.

@oleks-rip oleks-rip requested review from mvadari and ximinez April 16, 2026 22:07
@oleks-rip oleks-rip changed the title Stop tx processing if failed to delete expired credentials fix: Stop tx processing if failed to delete expired credentials Apr 16, 2026
@oleks-rip oleks-rip added this to the 3.1.3 (develop) milestone Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.6%. Comparing base (653a383) to head (9615e3d).

Files with missing lines Patch % Lines
src/libxrpl/tx/Transactor.cpp 25.0% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6962     +/-   ##
=========================================
- Coverage     81.6%   81.6%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        75992   76004     +12     
  Branches      7601    7606      +5     
=========================================
+ Hits         62013   62015      +2     
- Misses       13979   13989     +10     
Files with missing lines Coverage Δ
include/xrpl/basics/Buffer.h 100.0% <ø> (ø)
include/xrpl/core/JobTypes.h 98.8% <ø> (ø)
src/libxrpl/ledger/helpers/CredentialHelpers.cpp 98.3% <100.0%> (+0.7%) ⬆️
.../libxrpl/ledger/helpers/PermissionedDEXHelpers.cpp 95.7% <100.0%> (ø)
...pl/tx/transactors/credentials/CredentialAccept.cpp 100.0% <100.0%> (ø)
...pl/tx/transactors/credentials/CredentialDelete.cpp 100.0% <100.0%> (ø)
...xrpld/rpc/handlers/orderbook/DepositAuthorized.cpp 100.0% <100.0%> (ø)
src/libxrpl/tx/Transactor.cpp 91.7% <25.0%> (-0.6%) ⬇️

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ximinez ximinez changed the title fix: Stop tx processing if failed to delete expired credentials fix: Stop tx processing if failed to delete expired credentials (#6715) Apr 16, 2026
@github-actions
Copy link
Copy Markdown

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@github-actions
Copy link
Copy Markdown

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants