Skip to content

Remove depth, do not include node ID for leaf nodes

832a7e7
Select commit
Loading
Failed to load commit list.
Draft

perf: Replace node ID by depth in TMLedgerNode #6353

Remove depth, do not include node ID for leaf nodes
832a7e7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 13, 2026 in 1s

79.9% (target 75.0%)

View this Pull Request on Codecov

79.9% (target 75.0%)

Details

Codecov Report

❌ Patch coverage is 1.14943% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.9%. Comparing base (ac0ad36) to head (832a7e7).

Files with missing lines Patch % Lines
src/xrpld/app/ledger/detail/LedgerNodeHelpers.h 0.0% 36 Missing ⚠️
src/xrpld/app/ledger/detail/InboundLedger.cpp 0.0% 23 Missing ⚠️
...rc/xrpld/app/ledger/detail/InboundTransactions.cpp 0.0% 15 Missing ⚠️
src/xrpld/app/ledger/detail/InboundLedgers.cpp 0.0% 8 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp 0.0% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6353     +/-   ##
=========================================
- Coverage     79.9%   79.9%   -0.1%     
=========================================
  Files          842     843      +1     
  Lines        65538   65591     +53     
  Branches      7253    7286     +33     
=========================================
- Hits         52379   52377      -2     
- Misses       13159   13214     +55     
Files with missing lines Coverage Δ
src/libxrpl/shamap/SHAMapNodeID.cpp 77.6% <100.0%> (ø)
src/libxrpl/shamap/SHAMapSync.cpp 69.2% <ø> (+0.2%) ⬆️
src/xrpld/overlay/detail/PeerImp.cpp 5.6% <0.0%> (-<0.1%) ⬇️
src/xrpld/app/ledger/detail/InboundLedgers.cpp 37.6% <0.0%> (-0.2%) ⬇️
...rc/xrpld/app/ledger/detail/InboundTransactions.cpp 44.6% <0.0%> (-4.2%) ⬇️
src/xrpld/app/ledger/detail/InboundLedger.cpp 35.4% <0.0%> (-0.8%) ⬇️
src/xrpld/app/ledger/detail/LedgerNodeHelpers.h 0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.