refactor: Rename system name from 'ripple' to 'xrpld' #6347
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the core “system name” constant used across xrpld for default config/data directory selection (XDG + /etc/opt//var/opt) and for RPC metadata/user-agent strings, aligning with the ongoing rename effort in XLS-0095.
Changes:
- Update
systemName()from"ripple"to"xrpld".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| systemName() | ||
| { | ||
| static std::string const name = "ripple"; | ||
| static std::string const name = "xrpld"; |
There was a problem hiding this comment.
Changing systemName() to return "xrpld" breaks call sites that assume systemName() does NOT include the trailing 'd' (e.g., src/xrpld/app/main/Main.cpp prints systemName() << "d [options]...", which would become xrpldd). Either keep systemName() as the base name (e.g., "xrpl") and update the RPC/user-agent sites accordingly, or update the handful of call sites that append "d" so the CLI output remains correct.
| static std::string const name = "xrpld"; | |
| static std::string const name = "xrpl"; |
There was a problem hiding this comment.
@legleux The current path results in /etc/opt/ripple/xrpld.cfg.
Would you prefer this to be:
/etc/opt/xrpl/xrpld.cfg, or/etc/opt/xrpld/xrpld.cfg?
If the former, then I can change the system name to xrpl. If the latter, then I need to make some extra changes as pointed out by Copilot.
There was a problem hiding this comment.
That string appears in JSON-RPC response headers and as the User-Agent for HTTP requests so wouldn't that be an API-breaking change?
Usually I think the purported conventions for paths like this would be something like:
/opt/<vendor>/<application>
i.e.
/opt/[xrplf|rippled]/xrpld/bin/xrpldso if/when you install xrpld/clio/vkt, it all lives in the same place.
THAT BEING SAID, for simplicity sake just xrpld everywhere (which means you have to handle that lonely hanging d).
There was a problem hiding this comment.
Let's go for the latter for minimal confusion.
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
Not an issue for Clio 👍
May be an issue for someone else but i very much doubt.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6347 +/- ##
=========================================
- Coverage 79.9% 79.9% -0.0%
=========================================
Files 840 840
Lines 65514 65514
Branches 7245 7251 +6
=========================================
- Hits 52359 52350 -9
- Misses 13155 13164 +9
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
legleux
left a comment
legleux
left a comment
There was a problem hiding this comment.
Just the Copilot suggestion so we don't get xrpldd in certain places.
| systemName() | ||
| { | ||
| static std::string const name = "ripple"; | ||
| static std::string const name = "xrpld"; |
There was a problem hiding this comment.
Let's go for the latter for minimal confusion.
3 participants
High Level Overview of Change
This change modifies the system name from
rippledtoxrpld.Context of Change
Per XLS-0095, we are taking steps to rename ripple(d) to xrpl(d).
This change renames the system name, which is used in limited places:
--configflag, then the system name is used to construct the path where the config file and database may be stored, via the$XDG_CONFIG_HOMEand$XDG_DATA_HOMEdirectories, respectively.Type of Change
.gitignore, formatting, dropping support for older tooling)