fix: subscription webhook delivery stalling on HTTP errors #6344
+952
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
handleDatalogged "Complete." on EOF but never calledinvokeComplete(), leaking sockets until the 30s deadline timer firedsendThread()fired all queued events as concurrent async HTTP connections with no flow control, exhausting FDsChanges
HTTPClient (
src/libxrpl/net/HTTPClient.cpp)EOF path in
handleDatanow commits remaining response bytes and invokes the completion callback, matching the non-EOF path.RPCSub (
src/xrpld/rpc/detail/RPCSub.cpp)io_contextwith.run()for flow control (same pattern asrpcClient())Cleanup
io_contextparameter frommake_RPCSubsignature, constructor, and call siteboost/asio/io_context.hppinclude fromRPCSub.hUpstream issue
#6341
Test plan