Skip to content

Use std::bit_cast

6780d42
Select commit
Loading
Failed to load commit list.
Open

refactor: Use uint256 directly as key instead of void pointer #6313

Use std::bit_cast
6780d42
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 12, 2026 in 1s

79.9% (target 75.0%)

View this Pull Request on Codecov

79.9% (target 75.0%)

Details

Codecov Report

❌ Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.9%. Comparing base (11e8d1f) to head (6780d42).

Files with missing lines Patch % Lines
src/libxrpl/nodestore/backend/MemoryFactory.cpp 33.3% 2 Missing ⚠️
src/libxrpl/nodestore/backend/NuDBFactory.cpp 66.7% 2 Missing ⚠️
src/libxrpl/nodestore/backend/NullFactory.cpp 0.0% 2 Missing ⚠️
src/libxrpl/nodestore/backend/RocksDBFactory.cpp 60.0% 2 Missing ⚠️
src/libxrpl/nodestore/DatabaseNodeImp.cpp 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6313     +/-   ##
=========================================
- Coverage     79.9%   79.9%   -0.0%     
=========================================
  Files          840     840             
  Lines        65508   65503      -5     
  Branches      7248    7269     +21     
=========================================
- Hits         52354   52322     -32     
- Misses       13154   13181     +27     
Files with missing lines Coverage Δ
include/xrpl/nodestore/Backend.h 16.7% <ø> (ø)
src/libxrpl/nodestore/DatabaseRotatingImp.cpp 63.9% <100.0%> (ø)
src/libxrpl/nodestore/DatabaseNodeImp.cpp 41.7% <50.0%> (+5.1%) ⬆️
src/libxrpl/nodestore/backend/MemoryFactory.cpp 67.6% <33.3%> (-0.5%) ⬇️
src/libxrpl/nodestore/backend/NuDBFactory.cpp 64.0% <66.7%> (+0.2%) ⬆️
src/libxrpl/nodestore/backend/NullFactory.cpp 20.7% <0.0%> (ø)
src/libxrpl/nodestore/backend/RocksDBFactory.cpp 50.9% <60.0%> (ø)

... and 10 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.