Skip to content

squashed: Expand Number to support full integer range as of 9526a30 #6191

Closed
ximinez wants to merge 1 commit intoximinez/lending-3.1from
ximinez/lending-number-3.1
Closed

squashed: Expand Number to support full integer range as of 9526a30 #6191
ximinez wants to merge 1 commit intoximinez/lending-3.1from
ximinez/lending-number-3.1

Conversation

@ximinez
Copy link
Collaborator

@ximinez ximinez commented Jan 8, 2026

High Level Overview of Change

#6025 (ximinez/lending-number-simple) rebased onto #6156 (ximinez/lending-3.1).

Changes after the one noted will need to be manually synced across the two branches.

@ximinez ximinez requested a review from a team as a code owner January 8, 2026 18:54
@ximinez ximinez closed this Jan 8, 2026
@ximinez ximinez deleted the ximinez/lending-number-3.1 branch January 8, 2026 19:28
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 97.08333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.3%. Comparing base (e5a92fb) to head (d4a1f16).

Files with missing lines Patch % Lines
src/libxrpl/basics/Number.cpp 97.6% 5 Missing ⚠️
src/xrpld/app/tx/detail/LoanSet.cpp 70.6% 5 Missing ⚠️
include/xrpl/basics/Number.h 97.2% 2 Missing ⚠️
src/libxrpl/protocol/Issue.cpp 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           ximinez/lending-3.1   #6191     +/-   ##
=====================================================
+ Coverage                 79.3%   79.3%   +0.1%     
=====================================================
  Files                      837     838      +1     
  Lines                    71385   71660    +275     
  Branches                  8253    8263     +10     
=====================================================
+ Hits                     56591   56847    +256     
- Misses                   14794   14813     +19     
Files with missing lines Coverage Δ
include/xrpl/protocol/AmountConversions.h 87.7% <100.0%> (ø)
include/xrpl/protocol/IOUAmount.h 100.0% <100.0%> (ø)
include/xrpl/protocol/Issue.h 100.0% <ø> (ø)
include/xrpl/protocol/MPTIssue.h 100.0% <ø> (ø)
include/xrpl/protocol/Protocol.h 100.0% <ø> (ø)
include/xrpl/protocol/SField.h 100.0% <ø> (ø)
include/xrpl/protocol/STAmount.h 96.2% <100.0%> (+0.4%) ⬆️
include/xrpl/protocol/STNumber.h 100.0% <ø> (ø)
include/xrpl/protocol/SystemParameters.h 100.0% <ø> (ø)
src/libxrpl/protocol/IOUAmount.cpp 91.7% <100.0%> (+0.2%) ⬆️
... and 26 more

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant