feat: Add delegate filter param for account_tx RPC#6126
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6126 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 1036 1036
Lines 79870 79953 +83
Branches 8949 8948 -1
=======================================
+ Hits 65956 66039 +83
Misses 13905 13905
Partials 9 9
🚀 New features to boost your workflow:
|
|
A few suggestions to the new API:
|
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
|
/ai-review |
godexsoft
left a comment
There was a problem hiding this comment.
Few nits to fix/answer 👍
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
bthomee
left a comment
There was a problem hiding this comment.
Approving the latest commit containing newly added tests.
High Level Overview of Change
This PR adds the ability to filter account_tx results based on transaction delegation. This is useful for scenarios where one account (the delegatee) signs and submits a transaction on behalf of another account (the delegator).
Context of Change
New Request Parameter:
"delegate": {
"delegate_filter": "actor" or "authorizer",
"counter_party": "account_address"
}
Example: If User A submits a transaction to C on behalf of B:
User B (The account holder) can query with delegate_filter: "actor" to find transactions signed by others (like User A where A acted on behalf of B).
User A (The signer) can query with delegate_filter: "authorizer" to find transactions they signed for others (like User B, since B authorized A to act on their behalf).
The counter_party field can be used in either case to filter by a specific valid address
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)