fix: xrpld symlink renamed incorrectly

[legleux]

High Level Overview of Change

#5975 Changed the target of the xrpld symlink to xrpld and now points to itself.

We renamed the rippled target to xrpld but set the output binary to still be rippled so this symlink should not have been updated.

To be clear, this PR recreates the previous configuration:

bin
├── rippled
└── xrpld -> rippled

or we can just rip the band-aid off now and have rippled be a symlink to xrpld.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.3%. Comparing base (173f9f7) to head (d88cd1f).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #6012   +/-   ##
=======================================
  Coverage     78.3%   78.3%           
=======================================
  Files          816     816           
  Lines        68887   68887           
  Branches      8304    8303    -1     
=======================================
+ Hits         53943   53945    +2     
+ Misses       14944   14942    -2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bthomee]

Thanks - I'll push a commit to the renaming script as well soon.

[bthomee]

I updated the rename/cmake.sh script to achieve this programmatically.

Note that after running cmake --install build/Release --prefix custom_install I noticed that the order needed to be swapped to actually get the xrpld symlink to correctly point to rippled, as otherwise a rippled symlink would get created pointing to a non-existent xrpld.

We will rip off the bandaid soon, see #5983 (which still needs more work), but I do not plan to merge that until after 3.0.0 to avoid us having to update the deployment scripts in a rush.

[bthomee]

@legleux I also looked at the statement you said had no effect, even though on my machine it was complaining. I tried again and now it's compiling fine, so I also removed it from the script.

[a1q123456]

lgtm