-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix: Test Suite Names #5597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Afformativ
wants to merge
18
commits into
XRPLF:develop
Choose a base branch
from
Afformativ:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix: Test Suite Names #5597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first changes of test folders
update fix
Hi @Afformativ , thank you for opening the pull request. Please fill the PR context information as per the PR template.
|
changed the place where it was located RCL tests
removed the file that were deleted from github
Update to RCLValidations_test.cpp
Changed location RCLValidations_test.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
We have fixed the suite names all around the test files, to make them match to the folder name in which this test files are located. Also, we relocated RCL test files to consensus folder, because they are testing consensus functionality.
Context of Change
Large refactor of multiple test files to make more sense in testing functionality, now each test suite has the name of the folder in which the test files are located.
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)