Skip to content

Update to Boost 1.88 #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Conversation

godexsoft
Copy link
Collaborator

@godexsoft godexsoft commented Jul 16, 2025

High Level Overview of Change

This is a work in progress upgrade to boost 1.88.
A lot has changed between 1.83 and 1.88 so there are lots of changes in the diff, especially in regards to Boost.Asio and coroutines in particular.

There are several TODOs that i left around for the next guy (or future me).

Context of Change

Clio wants to move to 1.88 because that fixes several ASAN false positives around coroutine usage.
In order for Clio to move to newer boost, libXRPL needs to move too. Hence the changes in this PR.

Type of Change

  • Refactor (non-breaking change that only restructures code)

API Impact

  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)

@godexsoft godexsoft requested a review from a team as a code owner July 16, 2025 16:19
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 49.27536% with 140 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.7%. Comparing base (921aef9) to head (e0942ad).

Files with missing lines Patch % Lines
src/xrpld/overlay/detail/ConnectAttempt.cpp 0.0% 44 Missing ⚠️
src/libxrpl/beast/insight/StatsDCollector.cpp 0.0% 38 Missing ⚠️
src/libxrpl/basics/ResolverAsio.cpp 71.8% 11 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp 11.1% 8 Missing ⚠️
src/xrpld/app/main/Application.cpp 22.2% 7 Missing ⚠️
src/xrpld/app/misc/NetworkOPs.cpp 30.0% 7 Missing ⚠️
src/xrpld/net/detail/HTTPClient.cpp 41.7% 7 Missing ⚠️
src/xrpld/overlay/detail/OverlayImpl.h 0.0% 4 Missing ⚠️
include/xrpl/server/detail/BaseWSPeer.h 50.0% 3 Missing ⚠️
include/xrpl/beast/asio/io_latency_probe.h 83.3% 2 Missing ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5570     +/-   ##
=========================================
- Coverage     78.8%   78.7%   -0.1%     
=========================================
  Files          814     815      +1     
  Lines        71257   71332     +75     
  Branches      8365    8395     +30     
=========================================
+ Hits         56132   56147     +15     
- Misses       15125   15185     +60     
Files with missing lines Coverage Δ
include/xrpl/basics/ResolverAsio.h 100.0% <ø> (ø)
include/xrpl/json/json_reader.h 100.0% <100.0%> (ø)
include/xrpl/server/Server.h 100.0% <ø> (ø)
include/xrpl/server/Session.h 100.0% <ø> (ø)
include/xrpl/server/detail/BasePeer.h 57.9% <100.0%> (ø)
include/xrpl/server/detail/Door.h 79.7% <100.0%> (+0.1%) ⬆️
include/xrpl/server/detail/PlainHTTPPeer.h 93.8% <100.0%> (ø)
include/xrpl/server/detail/ServerImpl.h 92.5% <100.0%> (ø)
src/libxrpl/beast/net/IPAddressV4.cpp 100.0% <100.0%> (ø)
src/libxrpl/beast/net/IPAddressV6.cpp 100.0% <100.0%> (ø)
... and 40 more

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@godexsoft godexsoft changed the title experiment: Boost 1.88 Update to Boost 1.88 Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant