-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add support for DomainID
in MPTokenIssuance
transactions
#5509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DomainID
in MPTokenIssuance
transactions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5509 +/- ##
=======================================
Coverage 78.8% 78.8%
=======================================
Files 814 814
Lines 71163 71201 +38
Branches 8354 8331 -23
=======================================
+ Hits 56042 56106 +64
+ Misses 15121 15095 -26
🚀 New features to boost your workflow:
|
300fe81
to
b486cdf
Compare
13ae4bd
to
87282f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Couple of nit comments. Happy to approve otherwise.
…to ximinez/lending-refactoring-3 * XRPLF/ximinez/lending-refactoring-2: refactor: Update rocksdb (#5568) Switch instrumentation workflow to use dependencies (#5607) chore: Rename conan profile to `default` (#5599) Include `network_id` in validations and subscription stream responses (#5579) Add support for `DomainID` in `MPTokenIssuance` transactions (#5509) chore: Remove unused code after flow cross retirement (#5575) Remove obsolete owner pays fee feature and XRPL_ABANDON stanza (#5550) refactor: Makes HashRouter flags more type-safe (#5371) Fix clang-format CI job (#5598)
High Level Overview of Change
Add support for
DomainID
to existing transactionsMPTokenIssuanceCreate
andMPTokenIssuanceSet
Context of Change
In #5224 we added
DomainID
as an access control mechanism forSingleAssetVault
. The actual implementation of this feature lies inMPToken
andMPTokenIssuance
, hence it makes sense to enable the use ofDomainID
also inMPTokenIssuanceCreate
andMPTokenIssuanceSet
, following same rules as in Vault:MPTokenIssuanceCreate
andMPTokenIssuanceSet
can only setDomainID
if flagMPTRequireAuth
is setMPTokenIssuanceCreate
requires thatDomainID
be a non-zero, uint256 numberMPTokenIssuanceSet
allowsDomainID
to be zero (or empty) in which case it will removeDomainID
from theMPTokenIssuance
objectThe change is amendment-gated by
SingleAssetVault
.This is a non-breaking change because
SingleAssetVault
amendment isSupported::no
, i.e. at this moment considered a work in progress, which cannot be enabled on the network.Type of Change
.gitignore
, formatting, dropping support for older tooling)