Fix PriceDataSeries order on PriceOracle creation
#5485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5485 +/- ##
=========================================
- Coverage 78.4% 78.4% -0.0%
=========================================
Files 816 816
Lines 71710 71727 +17
Branches 8572 8578 +6
=========================================
+ Hits 56248 56258 +10
- Misses 15462 15469 +7
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bthomee
reviewed
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fixed an issue where the order of PriceDataSeries was out of sync between when PriceOracle was created and when it was updated.
Context of Change
Although they are registered in the canonical order when updated, they are created using the order specified in the transaction, so change so that they are also registered in the canonical order when created.
Type of Change
API Impact
no
Examples of data with issues
{ "AffectedNodes" : [ { "ModifiedNode" : { "FinalFields" : { "Account" : "rwhaYGnJMexktjhxAKzRwoCcQ2g6hvBDWu", "Balance" : "999999980", "Flags" : 8388608, "OwnerCount" : 1, "Sequence" : 6 }, "LedgerEntryType" : "AccountRoot", "LedgerIndex" : "2D6FE275B8B62F3B2C743090152CA05B8A28D5D20BEBED3A4B26745881180462", "PreviousFields" : { "Balance" : "999999990", "Sequence" : 5 }, "PreviousTxnID" : "18F8010465F8ABBE5A6DDF05E2AC5E9F28F7BA2B574FD1112B7B57C188E79F87", "PreviousTxnLgrSeq" : 4 } }, { "ModifiedNode" : { "FinalFields" : { "AssetClass" : "63757272656E6379", "Flags" : 0, "LastUpdateTime" : 946694820, "Owner" : "rwhaYGnJMexktjhxAKzRwoCcQ2g6hvBDWu", "OwnerNode" : "0", "PriceDataSeries" : [ { "PriceData" : { "AssetPrice" : "2c7", "BaseAsset" : "XRP", "QuoteAsset" : "EUR", "Scale" : 2 } }, { "PriceData" : { "AssetPrice" : "2e6", "BaseAsset" : "XRP", "QuoteAsset" : "USD", "Scale" : 2 } } ], "Provider" : "70726F7669646572", "URI" : "555249" }, "LedgerEntryType" : "Oracle", "LedgerIndex" : "72CD5C8AE42E0A993C1234E95B0F8A3BC7CADBD7097ACB23CC7B6DBFB06AA101", "PreviousFields" : { "LastUpdateTime" : 946694810, "PriceDataSeries" : [ { "PriceData" : { "AssetPrice" : "2e6", "BaseAsset" : "XRP", "QuoteAsset" : "USD", "Scale" : 2 } }, { "PriceData" : { "AssetPrice" : "2c7", "BaseAsset" : "XRP", "QuoteAsset" : "EUR", "Scale" : 2 } } ] }, "PreviousTxnID" : "18F8010465F8ABBE5A6DDF05E2AC5E9F28F7BA2B574FD1112B7B57C188E79F87", "PreviousTxnLgrSeq" : 4 } } ], "TransactionIndex" : 0, "TransactionResult" : "tesSUCCESS" }