Skip to content

Changes rippled to use east const convention #5409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

Tapanito
Copy link
Collaborator

@Tapanito Tapanito commented Apr 24, 2025

This PR refactors rippled codebase to use east const convention, and adds clang-format rule to follow this convention.

The PR is split into multiple commits for ease of reviewing.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@Tapanito Tapanito force-pushed the refactor/east-const branch from 7af310a to 8088afb Compare April 24, 2025 13:40
@Tapanito Tapanito marked this pull request as ready for review April 24, 2025 15:33
@Tapanito Tapanito requested a review from vvysokikh1 April 24, 2025 15:46
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 80.61224% with 57 lines in your changes missing coverage. Please review.

Project coverage is 78.1%. Comparing base (405f461) to head (9bdb66a).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/ledger/LedgerHistory.cpp 3.4% 28 Missing ⚠️
src/libxrpl/json/json_valueiterator.cpp 61.5% 5 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp 20.0% 4 Missing ⚠️
src/xrpld/consensus/Consensus.h 62.5% 3 Missing ⚠️
src/xrpld/core/detail/Job.cpp 25.0% 3 Missing ⚠️
src/xrpld/peerfinder/detail/Logic.h 0.0% 3 Missing ⚠️
src/xrpld/app/tx/detail/CancelOffer.cpp 50.0% 2 Missing ⚠️
include/xrpl/protocol/STArray.h 50.0% 1 Missing ⚠️
src/libxrpl/json/json_reader.cpp 83.3% 1 Missing ⚠️
src/libxrpl/protocol/STBase.cpp 80.0% 1 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5409   +/-   ##
=======================================
  Coverage     78.1%   78.1%           
=======================================
  Files          795     795           
  Lines        68598   68601    +3     
  Branches      8283    8281    -2     
=======================================
+ Hits         53580   53589    +9     
+ Misses       15018   15012    -6     
Files with missing lines Coverage Δ
include/xrpl/basics/BasicConfig.h 87.2% <100.0%> (ø)
include/xrpl/basics/CompressionAlgorithms.h 0.0% <ø> (ø)
include/xrpl/basics/Expected.h 100.0% <ø> (ø)
include/xrpl/basics/TaggedCache.h 100.0% <ø> (ø)
include/xrpl/basics/TaggedCache.ipp 85.6% <ø> (ø)
include/xrpl/basics/base_uint.h 96.8% <100.0%> (ø)
include/xrpl/basics/partitioned_unordered_map.h 99.2% <ø> (ø)
include/xrpl/basics/tagged_integer.h 100.0% <100.0%> (ø)
include/xrpl/beast/utility/temp_dir.h 100.0% <ø> (ø)
include/xrpl/json/json_reader.h 100.0% <ø> (ø)
... and 141 more

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant