Skip to content

chore: Renames docs job and runs on shared runner #5398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bthomee
Copy link
Collaborator

@bthomee bthomee commented Apr 10, 2025

High Level Overview of Change

Renames the docs job from job to documentation for better readability, and makes it run on the shared runner.

Context of Change

We were pulling our Docker images from DockerHub without logging in, causing us to run into rate limits. To solve this, the images were pushed to our GitHub registry, but the documentation pipeline cannot access them as it runs on the GitHub runner instead of our own runner. This change makes the pipeline run on our shared runner.

As the documentation job name job is meaningless, this PR renames it to documentation.

Type of Change

  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Apr 10, 2025
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.1%. Comparing base (c4308b2) to head (9f32236).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5398   +/-   ##
=======================================
  Coverage     78.1%   78.1%           
=======================================
  Files          795     795           
  Lines        68598   68599    +1     
  Branches      8278    8277    -1     
=======================================
+ Hits         53593   53595    +2     
+ Misses       15005   15004    -1     

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bthomee bthomee requested a review from legleux April 10, 2025 15:24
@bthomee bthomee marked this pull request as ready for review April 10, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant