Proposed 1.10.0-b2 #4321
Merged
Proposed 1.10.0-b2 #4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the feature enabled by the tfTrustLine flag on an NFTokenMint transaction could be used as a means to attack the NFToken issuer. Details are in XRPLF#4300 The fixRemoveNFTokenAutoTrustLine amendment removes the ability to set the tfTrustLine flag on an NFTokenMint transaction. Closes 4300.
Compiling with gcc 12 on manjaro (arch variant) had compilation errors without adding an additional include file.
minumum -> minimum
Boost intrusive renamed the `comp()` function -> `get_comp()`
manojsdoshi
force-pushed
the
develop-next
branch
from
1cc8b34 to
cee8348
Compare
manojsdoshi
force-pushed
the
develop-next
branch
from
cee8348 to
ebbf4b6
Compare
nbougalis
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this PR will:
close #4305
close #4299
close #4274
close #4272
close #4246
close #4242
close #4167
close #4157