Skip to content

fix: Use ytanikin/pr-conventional-commits action for conventional com… #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

mathbunnyru
Copy link
Collaborator

@mathbunnyru mathbunnyru commented Apr 27, 2025

…mits check

There are 2 actions with almost the same name from the same author:

I've merged this change to my develop branch in my fork and created a PR on to test it works: mathbunnyru#3

I will update the upstream issue and suggest author to archive the old action: ytanikin/pr-conventional-commits#19

Copy link

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.76%. Comparing base (427ba47) to head (ec16515).
Report is 74 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2049      +/-   ##
===========================================
+ Coverage    72.71%   72.76%   +0.05%     
===========================================
  Files          333      355      +22     
  Lines        13525    14697    +1172     
  Branches      6881     7464     +583     
===========================================
+ Hits          9835    10695     +860     
- Misses        1785     1975     +190     
- Partials      1905     2027     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru
Copy link
Collaborator Author

I think now this action runs in a PR, that's why github token doesn't have any permissions, but when we merge it to develop, it might work fine.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try the new one and see if it works in develop. Should be easy to fix/change if it does not.

@mathbunnyru mathbunnyru merged commit b51ed8d into XRPLF:develop Apr 28, 2025
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants