template and language definition for include/defines.php

[liomj]

hi

is it possible to have a template and language definition for this page when our server or db have problem

its all hardcoded now...

[GregMage]

This is a good idea.I think this improvement needs to be integrated in version 2.6 and not in 2.5.9

[geekwright]

The definition of _XOOPS_FATAL_MESSAGE really should not be in include/define.php.

It should be separated, but it really cannot take part in template overrides or localization like other parts of the system. It is used inside error and exception handlers, and at that point we have no reliable system to depend on. The database could be broken, so we have no configs, or smarty could have an issue, so we have no templates. It also is imperative that we do nothing in the code that could create another error or exception.

Having to deal with those circumstances seriously limits our options. I'm sure we can improve it in some ways, but it will always be "different" because of the circumstances that it has to deal with.

One possible solution is to separate the definition in to a separate file. Before loading that file, check for the existence of a single override file of a specific name and location. If that file exists, load it, otherwise load the system supplied version. It would still be one definition for the whole system, but it would be customized and would not be overwritten in system upgrades.