'each' was removed in PHP 8.0

[mambax7]

\htdocs\modules\system\class\cookie.php line 56
list($k, $v) = each($key);
same in line 103, 132, 198

Same in \htdocs\class\snoopy.php line 175, 223, etc.

[mambax7]

"money_format" was also removed in PHP 8.0 (\htdocs\language\english\locale.php)

[geekwright]

These are quite different situations. Moved money_format to a separate issue.

[geekwright]

Cookie and Snoopy are both deprecated and unreferenced in core.

Cookie is deprecated since 2.5.9, so removal is the obvious option.

Snoopy was deprecated in the current cycle, but it needs to die.

Any feel for what all still uses Snoopy?

[mambax7]

Happy_linux and some of its modules are still using Snoopy, e.g.:
https://github.com/mambax7/happy_linux/blob/master/class/RemoteFile.php

I've tried to change it yesterday to the recommended:

$this->_snoopy = new \XoopsHttpGet('');

but ran into problems, because some of the Snoopy functionality used by Happy_linux was not implemented in XoopsHttpGet, e.g.:

    //=========================================================
    // use class spoopy
    //=========================================================
    /**
     * @param        $host
     * @param string $port
     * @param string $user
     * @param string $pass
     */
    public function set_snoopy_proxy($host, $port = '8080', $user = '', $pass = '')
    {
        $this->set_remote_mode(1);  // use snoopy

        $this->_snoopy->proxy_host = $host;
        $this->_snoopy->proxy_port = $port;

        if ($user) {
            $this->_snoopy->proxy_user = $user;
        }
        if ($pass) {
            $this->_snoopy->proxy_pass = $pass;
        }
    }

    /**
     * @param $time
     */
    public function set_snoopy_timeout_connect($time)
    {
        if ((int)$time > 0) {
            $this->_snoopy->_fp_timeout = (float)$time;
        }
    }

    /**
     * @param $time
     */
    public function set_snoopy_timeout_read($time)
    {
        if ((int)$time > 0) {
            $this->_snoopy->read_timeout = (float)$time;
        }
    }

But I looked into only very briefly, so I don't know if that was needed at all.

I guess, we would need a more detailed tutorial on how to convert Snoopy calls to XoopsHttpGet

[geekwright]

An example of a conversion in core is here:
f1a594b

XoopsHttpGet is a streamlined way to fetch from a remote URL. It does not have lots of options, nor is it built in pieces. It is just a no nonfrills fetch. This was the number one use for Snoopy. XoopsHttpGet is not a direct replacement, it provides the needed functionality so you don't need Snoopy to do a GET from a URL. Similar classes could be added for Post and Put requests.

Sample code:

XoopsLoad::load('xoopshttpget');

try {
    $httpGet = new XoopsHttpGet($url);
} catch (\RuntimeException $e) {
    // deal with the failure here and leave
    echo $e->getMessage() . '<br>';
    ...
}
// we are set to fetch the data
$data = $httpGet->fetch();
if (false === $data) {
    // deal with the failure here
    echo $httpGet->getError() . '<br>';
} else {
    // do stuff with $data from $url
}

As for XoopsModules\Happylinux\RemoteFile, look at what is using RemoteFile and determine what needs to be refactored to make it Snoopy free.

[geekwright]

BTW, Guzzle could be a good long term solution.
https://docs.guzzlephp.org/en/stable/quickstart.html

[mambax7]

Thanks for addressing the issues in XOOPS 2.5.11.
And thanks for the pointer to the conversion. If I find time, I'll look into it, but to be honest, I might just let the old Happy_linux modules die - it might be not worth the effort to keep them updated. I need to focus more on currently used modules, like Publisher, etc.