Skip to content

Align behaviour of expect_references with docs #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MatthiasValvekens
Copy link
Contributor

Passing expect_references=True to verify(...) now results in a list of verify_results, irrespective of the number of references in the signature.

Fixes #278.

Passing expect_references=True to verify(...) now
results in a list of verify_results, irrespective of the number
of references in the signature.

Fixes XML-Security#278.
@MatthiasValvekens MatthiasValvekens force-pushed the bugfix/verify-return-type branch from 416913a to d45d962 Compare August 19, 2025 10:38
@MatthiasValvekens
Copy link
Contributor Author

Thanks for the swift review! You might have to do the honours of merging the PR yourself, though--I don't have merge access here :).

@kislyuk kislyuk merged commit 9fbf845 into XML-Security:main Aug 20, 2025
22 checks passed
@kislyuk
Copy link
Member

kislyuk commented Aug 20, 2025

Thanks for the swift review! You might have to do the honours of merging the PR yourself, though--I don't have merge access here :).

Would you like to? :)

You've done a great job maintaining python-pkcs11, would be happy to have you on board here if interested.

@MatthiasValvekens
Copy link
Contributor Author

Thanks! I'd be happy to help out here and there, but chances are that it won't be to the same extent as for python-pkcs11. The main reason is bandwidth (as always). In addition to that, my exposure to python-pkcs11 as a dependency has always been quite significant, so I had a very direct incentive to fix stuff there, and I also was much more familiar with the lib's internals already.

As for signxml: my pyhanko lib will have an optional dependency on signxml starting in the next release, so chances are that I'll wind up contributing more bugfixes in the future. But things like helping with clearing the backlog of issues/open PRs/etc. probably isn't in the cards in the short/mid term.

Up to you to decide if making me a collaborator on this project makes sense given that context. Collaborator or outside contributor: I'm fine with either :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing a bool to expect_references always results in a singular result
2 participants