fix(tests): switch class tests to use basic character client constructor

XIVStats · Feb 6, 2022 · 0979a3b · 0979a3b
1 parent a50af60
commit 0979a3b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -53,9 +53,13 @@ module.exports = {
   },
   overrides: [
     {
+      // Disable doc rules for tests, we declare internal functions as helpers we don't need to doc them
       files: ['src/**/*.test.ts'],
       rules: {
         '@typescript-eslint/ban-ts-comment': 'off',
+        'jsdoc/require-returns': 'off',
+        'jsdoc/require-param-type': 'off',
+        'jsdoc/require-param-description': 'off',
       },
     },
   ],

diff --git a/src/client/__tests__/LodestoneClient.test.ts b/src/client/__tests__/LodestoneClient.test.ts
@@ -100,7 +100,6 @@ class TestLodestoneClient extends LodestoneClient<number, IDummy, Dummy> {
   }
 }
 
-// eslint-disable-next-line jsdoc/require-returns
 /**
  * @param code
  */

diff --git a/src/client/error/LodestoneMaintenanceError.ts b/src/client/error/LodestoneMaintenanceError.ts
@@ -26,7 +26,7 @@
 import LodestoneError from './LodestoneError'
 import RequestStatus from '../category/RequestStatus'
 import RequestFailureCategory from '../category/RequestFailureCategory'
-import { ILodestoneMaintenanceFailure, IRejectedRequestFailure } from '../interface/IResponse'
+import { ILodestoneMaintenanceFailure } from '../interface/IResponse'
 
 export default class LodestoneMaintenanceError<TypeOfIdentifier> extends LodestoneError<TypeOfIdentifier> {
   private static STATUS: RequestStatus.LodestoneMaintenance = RequestStatus.LodestoneMaintenance

diff --git a/src/entity/character/attribute/class/__itests__/Class.itest.ts b/src/entity/character/attribute/class/__itests__/Class.itest.ts
@@ -31,16 +31,16 @@ import LocalizedClientFactory from '../../../../../locale/LocalizedClientFactory
 import IClass from '../interface/IClass'
 import ClassConfig from '../../../config/ClassConfig'
 import Class from '../Class'
-import CreatureClient from '../../../../../client/entity/CreatureClient'
+import CharacterClient from '../../../../../client/entity/CharacterClient'
 
 describe('Class [integration]', () => {
   describe('given the translation values provided, and icon mappings', () => {
     const testLanguages = [Language.en, Language.enUs, Language.de, Language.fr, Language.ja]
-    let client: CreatureClient
+    let client: CharacterClient
     const testCharacterId = 1557260
 
     beforeAll(() => {
-      client = new CreatureClient({
+      client = new CharacterClient({
         axiosInstances: LocalizedClientFactory.createClientsForLanguages(testLanguages),
       })
     })