Repository navigation
Conversation
A client can truncate the shared memory backing a DRI3/xshmfence sync fence and cause SIGBUS when the server accesses it. Register the mapping with busfault and wrap xshmfence accesses with sigsetjmp so truncation unwinds safely, then discard the mapping while keeping the fence XID. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com> Assisted-by: AI Closes: https://gitlab.freedesktop.org/xorg/xserver/-/work_items/1911 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2270> (cherry picked from commit cd083d9)
metux
pushed a commit
that referenced
this pull request
Oct 16, 2026
A client can truncate the shared memory backing a DRI3/xshmfence sync fence and cause SIGBUS when the server accesses it. Register the mapping with busfault and wrap xshmfence accesses with sigsetjmp so truncation unwinds safely, then discard the mapping while keeping the fence XID. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com> Assisted-by: AI Closes: https://gitlab.freedesktop.org/xorg/xserver/-/work_items/1911 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2270> (cherry picked from commit cd083d9) PR: #4015
Contributor
Author
Summary: Adds BUSFAULT-guarded SIGBUS handling to miext/sync/misyncshm.c. Sync SHM fences now register with the busfault subsystem (introduced in #4016) and use sigsetjmp/siglongjmp to safely handle truncated shared memory fences instead of crashing. Includes fence discard on SIGBUS and registration on fence creation. Assessment:
Label: bot-review-passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client can truncate the shared memory backing a DRI3/xshmfence sync
fence and cause SIGBUS when the server accesses it.
Register the mapping with busfault and wrap xshmfence accesses with
sigsetjmp so truncation unwinds safely, then discard the mapping while
keeping the fence XID.
Signed-off-by: Olivier Fourdan ofourdan@redhat.com
Assisted-by: AI
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/work_items/1911
Part-of: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/2270
(cherry picked from commit cd083d9)